Skip to content

Commit 28bba0d

Browse files
authored
Bump minimum MSVC version by one dot release to VS 2019 16.8 (llvm#118833)
This is a small change, but unblocks using longer string literals in LLVM's source code, and hopefully isn't disruptive. Discussed in an RFC here: https://discourse.llvm.org/t/rfc-raising-minimum-msvc-version-by-one-dot-release/
1 parent 2c7ece2 commit 28bba0d

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

llvm/cmake/modules/CheckCompilerVersion.cmake

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ set(APPLECLANG_MIN 10.0)
1212
set(APPLECLANG_SOFT_ERROR 10.0)
1313

1414
# https://en.wikipedia.org/wiki/Microsoft_Visual_C#Internal_version_numbering
15-
# _MSC_VER == 1927 MSVC++ 14.27 Visual Studio 2019 Version 16.7
16-
set(MSVC_MIN 19.27)
17-
set(MSVC_SOFT_ERROR 19.27)
15+
# _MSC_VER == 1928 MSVC++ 19.27 Visual Studio 2019 Version 16.8 + 16.9
16+
set(MSVC_MIN 19.28)
17+
set(MSVC_SOFT_ERROR 19.28)
1818

1919
set(LIBSTDCXX_MIN 7)
2020
set(LIBSTDCXX_SOFT_ERROR 7)

llvm/docs/GettingStarted.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,7 @@ popular host toolchains for specific minimum versions in our build systems:
356356
* Clang 5.0
357357
* Apple Clang 10.0
358358
* GCC 7.4
359-
* Visual Studio 2019 16.7
359+
* Visual Studio 2019 16.8
360360

361361
Anything older than these toolchains *may* work, but will require forcing the
362362
build system with a special option and is not really a supported host platform.

llvm/docs/ReleaseNotes.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,8 @@ Changes to LLVM infrastructure
113113
Changes to building LLVM
114114
------------------------
115115

116+
* Raised the minimum MSVC version to Visual Studio 2019 16.8.
117+
116118
Changes to TableGen
117119
-------------------
118120

0 commit comments

Comments
 (0)