Merge pull request #8828 from felipepiovezan/felipe/fix_async_bt_location_6

[lldb][swift] Fix zeroth frame detection in async functions

Author: fredriss

lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntime.cpp

@@ -2771,7 +2771,6 @@ SwiftLanguageRuntime::GetRuntimeUnwindPlan(ProcessSP process_sp,
   plan->SetSourcedFromCompiler(eLazyBoolNo);
   plan->SetUnwindPlanValidAtAllInstructions(eLazyBoolYes);
   plan->SetUnwindPlanForSignalTrap(eLazyBoolYes);
-  behaves_like_zeroth_frame = true;
   return plan;
 }
 

lldb/test/API/lang/swift/async/unwind/sayhello/TestSwiftAsyncUnwind.py

@@ -32,3 +32,22 @@ def test(self):
         # to see that this is really the async unwinder.
         self.assertIn(thread.GetFrameAtIndex(1).GetRegisters().GetSize(), [2,3,4])
         self.assertIn(thread.GetFrameAtIndex(2).GetRegisters().GetSize(), [2,3,4])
+
+        # Delete the old breakpoint, otherwise it would be reached again.
+        target.BreakpointDelete(bkpt.GetID())
+        lldbutil.continue_to_source_breakpoint(
+            self, process, "break synchronous hello", src
+        )
+
+        self.assertTrue(
+            "synchronousSayHelo" in thread.GetFrameAtIndex(0).GetFunctionName(),
+        )
+        frame1 = thread.GetFrameAtIndex(1)
+        self.assertTrue(
+            "callSyncHello" in frame1.GetFunctionName(),
+        )
+        location = frame1.GetLineEntry()
+        # Check that the callsite location is on the correct line.
+        self.assertEqual(
+            location.GetLine(), lldbtest.line_number("main.swift", "frame 1 line")
+        )

lldb/test/API/lang/swift/async/unwind/sayhello/main.swift

@@ -20,9 +20,18 @@ func sayGeneric<T>(_ msg: T) async {
   print("\(str) after calls - arg \(msg)")
 }
 
+func synchronousSayHelo() {
+  print("synchronously saying hello") // break synchronous hello
+}
+
+func callSyncHello() async {
+  synchronousSayHelo() // frame 1 line
+}
+
 @main struct Main {
   static func main() async {
     await sayGeneric("world")
     await sayHello()
+    await callSyncHello()
   }
 }