Merge pull request #5851 from jkorous-apple/revert-safe-buffers-cherry-pick

Revert "Revert "Revert "[-Wunsafe-buffer-usage] Initial commit - Tran…

Author: jkorous-apple

clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h

@@ -11726,9 +11726,4 @@ def err_cast_from_randomized_struct : Error<
 // LoongArch-specific Diagnostics
 def err_loongarch_builtin_requires_la64 : Error<
   "this builtin requires target: loongarch64">;
-
-// Unsafe buffer usage diagnostics.
-def warn_unsafe_buffer_usage : Warning<
-  "unchecked operation on raw buffer in expression">,
-  InGroup<DiagGroup<"unsafe-buffer-usage">>, DefaultIgnore;
 } // end of sema component.

clang/include/clang/Basic/DiagnosticSemaKinds.td

@@ -32,7 +32,6 @@ add_clang_library(clangAnalysis
   ThreadSafetyLogical.cpp
   ThreadSafetyTIL.cpp
   UninitializedValues.cpp
-  UnsafeBufferUsage.cpp
 
   LINK_LIBS
   clangAST

clang/lib/Analysis/CMakeLists.txt

@@ -29,7 +29,6 @@
 #include "clang/Analysis/Analyses/ReachableCode.h"
 #include "clang/Analysis/Analyses/ThreadSafety.h"
 #include "clang/Analysis/Analyses/UninitializedValues.h"
-#include "clang/Analysis/Analyses/UnsafeBufferUsage.h"
 #include "clang/Analysis/AnalysisDeclContext.h"
 #include "clang/Analysis/CFG.h"
 #include "clang/Analysis/CFGStmtMap.h"
@@ -2141,23 +2140,6 @@ class ConsumedWarningsHandler : public ConsumedWarningsHandlerBase {
 } // namespace consumed
 } // namespace clang
 
-//===----------------------------------------------------------------------===//
-// Unsafe buffer usage analysis.
-//===----------------------------------------------------------------------===//
-
-class UnsafeBufferUsageReporter : public UnsafeBufferUsageHandler {
-  Sema &S;
-
-public:
-  UnsafeBufferUsageReporter(Sema &S) : S(S) {}
-
-  void handleUnsafeOperation(const Stmt *Operation) override {
-    S.Diag(Operation->getBeginLoc(), diag::warn_unsafe_buffer_usage)
-        << Operation->getSourceRange();
-  }
-};
-
-
 //===----------------------------------------------------------------------===//
 // AnalysisBasedWarnings - Worker object used by Sema to execute analysis-based
 //  warnings on a function, method, or block.
@@ -2450,12 +2432,6 @@ void clang::sema::AnalysisBasedWarnings::IssueWarnings(
       if (S.getLangOpts().CPlusPlus && isNoexcept(FD))
         checkThrowInNonThrowingFunc(S, FD, AC);
 
-  // Emit unsafe buffer usage warnings and fixits.
-  if (!Diags.isIgnored(diag::warn_unsafe_buffer_usage, D->getBeginLoc())) {
-    UnsafeBufferUsageReporter R(S);
-    checkUnsafeBufferUsage(D, R);
-  }
-
   // If none of the previous checks caused a CFG build, trigger one here
   // for the logical error handler.
   if (LogicalErrorHandler::hasActiveDiagnostics(Diags, D->getBeginLoc())) {