Skip to content

Commit 2b1c76c

Browse files
[Github] Use three dot diff for darker in code format action (llvm#74704)
Using a two dot diff allows changes made in main after the merge base to show up in the formatting diff. Using a three dot diff fixes this and ensures that only changes made in the source branch (branch from the PR author) will get passed along to the formatter. Without this, issues like llvm#73873 occur.
1 parent 50ed0ba commit 2b1c76c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

llvm/utils/git/code-format-helper.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ def format_run(
185185
"--check",
186186
"--diff",
187187
"-r",
188-
f"{args.start_rev}..{args.end_rev}",
188+
f"{args.start_rev}...{args.end_rev}",
189189
] + py_files
190190
print(f"Running: {' '.join(darker_cmd)}")
191191
self.darker_cmd = darker_cmd

0 commit comments

Comments
 (0)