[Mach0] Fix unused-variable warnings

Gabriel Hjort Åkerlund · dstenb · commit 2d1f471e45af · 2020-11-19T10:51:15.000+01:00
Reviewed By: arsenm Differential Revision: https://reviews.llvm.org/D91519
diff --git a/lld/MachO/SymbolTable.cpp b/lld/MachO/SymbolTable.cpp
@@ -134,7 +134,7 @@ Symbol *SymbolTable::addDSOHandle(const MachHeaderSection *header) {
     // FIXME: Make every symbol (including absolute symbols) contain a
     // reference to their originating file, then add that file name to this
     // error message.
-    if (auto *defined = dyn_cast<Defined>(s))
+    if (isa<Defined>(s))
       error("found defined symbol with illegal name " + DSOHandle::name);
   }
   replaceSymbol<DSOHandle>(s, header);

Original file line number	Diff line number	Diff line change
`@@ -134,7 +134,7 @@ Symbol SymbolTable::addDSOHandle(const MachHeaderSection header) {`
`134`	`134`	`// FIXME: Make every symbol (including absolute symbols) contain a`
`135`	`135`	`// reference to their originating file, then add that file name to this`
`136`	`136`	`// error message.`
`137`		`- if (auto *defined = dyn_cast<Defined>(s))`
	`137`	`+ if (isa<Defined>(s))`
`138`	`138`	`error("found defined symbol with illegal name " + DSOHandle::name);`
`139`	`139`	`}`
`140`	`140`	`replaceSymbol<DSOHandle>(s, header);`