Skip to content

Commit 2ea14f2

Browse files
authored
Merge pull request #7784 from augusto2112/fix-lldb-log
[lldb] Fix LLDB_LOG with format specifier argument
2 parents 487436d + be39030 commit 2ea14f2

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

lldb/source/Plugins/ExpressionParser/Swift/SwiftUserExpression.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -667,7 +667,7 @@ bool SwiftUserExpression::Parse(DiagnosticManager &diagnostic_manager,
667667

668668
auto error = [&](const char *error_msg, const char *detail = nullptr) {
669669
if (detail)
670-
LLDB_LOG(log, "%s: %s", error_msg, detail);
670+
LLDB_LOG(log, "{0}: {1}", error_msg, detail);
671671
else
672672
LLDB_LOG(log, error_msg);
673673

lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeDynamicTypeResolution.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -663,7 +663,7 @@ SwiftLanguageRuntimeImpl::GetNumChildren(CompilerType type,
663663
if (auto *rti =
664664
llvm::dyn_cast_or_null<swift::reflection::RecordTypeInfo>(cti)) {
665665
LLDB_LOG(GetLog(LLDBLog::Types),
666-
"%s: class RecordTypeInfo(num_fields=%i)",
666+
"{0}: class RecordTypeInfo(num_fields=%i)",
667667
type.GetMangledTypeName().GetCString(), rti->getNumFields());
668668

669669
// The superclass, if any, is an extra child.
@@ -675,7 +675,7 @@ SwiftLanguageRuntimeImpl::GetNumChildren(CompilerType type,
675675
return {};
676676
}
677677
// FIXME: Implement more cases.
678-
LLDB_LOG(GetLog(LLDBLog::Types), "%s: unimplemented type info",
678+
LLDB_LOG(GetLog(LLDBLog::Types), "{0}: unimplemented type info",
679679
type.GetMangledTypeName().GetCString());
680680
return {};
681681
}

lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -590,7 +590,7 @@ TypeSystemSwiftTypeRef::ResolveTypeAlias(swift::Demangle::Demangler &dem,
590590
}
591591
NodePointer n = GetDemangledType(dem, desugared_name.GetStringRef());
592592
if (!n) {
593-
LLDB_LOG(GetLog(LLDBLog::Types), "Unrecognized demangling %s",
593+
LLDB_LOG(GetLog(LLDBLog::Types), "Unrecognized demangling {0}",
594594
desugared_name.AsCString());
595595
return {{}, {}};
596596
}

0 commit comments

Comments
 (0)