Skip to content

Commit 3204ffe

Browse files
committed
[PowerPC] [NFC] Rename VCMPo to VCMP_rec
Reviewed By: jsji Differential Revision: https://reviews.llvm.org/D90581
1 parent fb6d1c0 commit 3204ffe

File tree

6 files changed

+49
-49
lines changed

6 files changed

+49
-49
lines changed

llvm/lib/Target/PowerPC/PPCISelLowering.cpp

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1463,7 +1463,7 @@ const char *PPCTargetLowering::getTargetNodeName(unsigned Opcode) const {
14631463
case PPCISD::ANDI_rec_1_GT_BIT:
14641464
return "PPCISD::ANDI_rec_1_GT_BIT";
14651465
case PPCISD::VCMP: return "PPCISD::VCMP";
1466-
case PPCISD::VCMPo: return "PPCISD::VCMPo";
1466+
case PPCISD::VCMP_rec: return "PPCISD::VCMP_rec";
14671467
case PPCISD::LBRX: return "PPCISD::LBRX";
14681468
case PPCISD::STBRX: return "PPCISD::STBRX";
14691469
case PPCISD::LFIWAX: return "PPCISD::LFIWAX";
@@ -10460,7 +10460,7 @@ SDValue PPCTargetLowering::LowerINTRINSIC_WO_CHAIN(SDValue Op,
1046010460
DAG.getConstant(CompareOpc, dl, MVT::i32)
1046110461
};
1046210462
EVT VTs[] = { Op.getOperand(2).getValueType(), MVT::Glue };
10463-
SDValue CompNode = DAG.getNode(PPCISD::VCMPo, dl, VTs, Ops);
10463+
SDValue CompNode = DAG.getNode(PPCISD::VCMP_rec, dl, VTs, Ops);
1046410464

1046510465
// Now that we have the comparison, emit a copy from the CR to a GPR.
1046610466
// This is flagged to the above dot comparison.
@@ -15148,43 +15148,43 @@ SDValue PPCTargetLowering::PerformDAGCombine(SDNode *N,
1514815148
}
1514915149
break;
1515015150
case PPCISD::VCMP:
15151-
// If a VCMPo node already exists with exactly the same operands as this
15152-
// node, use its result instead of this node (VCMPo computes both a CR6 and
15153-
// a normal output).
15151+
// If a VCMP_rec node already exists with exactly the same operands as this
15152+
// node, use its result instead of this node (VCMP_rec computes both a CR6
15153+
// and a normal output).
1515415154
//
1515515155
if (!N->getOperand(0).hasOneUse() &&
1515615156
!N->getOperand(1).hasOneUse() &&
1515715157
!N->getOperand(2).hasOneUse()) {
1515815158

15159-
// Scan all of the users of the LHS, looking for VCMPo's that match.
15160-
SDNode *VCMPoNode = nullptr;
15159+
// Scan all of the users of the LHS, looking for VCMP_rec's that match.
15160+
SDNode *VCMPrecNode = nullptr;
1516115161

1516215162
SDNode *LHSN = N->getOperand(0).getNode();
1516315163
for (SDNode::use_iterator UI = LHSN->use_begin(), E = LHSN->use_end();
1516415164
UI != E; ++UI)
15165-
if (UI->getOpcode() == PPCISD::VCMPo &&
15165+
if (UI->getOpcode() == PPCISD::VCMP_rec &&
1516615166
UI->getOperand(1) == N->getOperand(1) &&
1516715167
UI->getOperand(2) == N->getOperand(2) &&
1516815168
UI->getOperand(0) == N->getOperand(0)) {
15169-
VCMPoNode = *UI;
15169+
VCMPrecNode = *UI;
1517015170
break;
1517115171
}
1517215172

15173-
// If there is no VCMPo node, or if the flag value has a single use, don't
15174-
// transform this.
15175-
if (!VCMPoNode || VCMPoNode->hasNUsesOfValue(0, 1))
15173+
// If there is no VCMP_rec node, or if the flag value has a single use,
15174+
// don't transform this.
15175+
if (!VCMPrecNode || VCMPrecNode->hasNUsesOfValue(0, 1))
1517615176
break;
1517715177

1517815178
// Look at the (necessarily single) use of the flag value. If it has a
1517915179
// chain, this transformation is more complex. Note that multiple things
1518015180
// could use the value result, which we should ignore.
1518115181
SDNode *FlagUser = nullptr;
15182-
for (SDNode::use_iterator UI = VCMPoNode->use_begin();
15182+
for (SDNode::use_iterator UI = VCMPrecNode->use_begin();
1518315183
FlagUser == nullptr; ++UI) {
15184-
assert(UI != VCMPoNode->use_end() && "Didn't find user!");
15184+
assert(UI != VCMPrecNode->use_end() && "Didn't find user!");
1518515185
SDNode *User = *UI;
1518615186
for (unsigned i = 0, e = User->getNumOperands(); i != e; ++i) {
15187-
if (User->getOperand(i) == SDValue(VCMPoNode, 1)) {
15187+
if (User->getOperand(i) == SDValue(VCMPrecNode, 1)) {
1518815188
FlagUser = User;
1518915189
break;
1519015190
}
@@ -15194,7 +15194,7 @@ SDValue PPCTargetLowering::PerformDAGCombine(SDNode *N,
1519415194
// If the user is a MFOCRF instruction, we know this is safe.
1519515195
// Otherwise we give up for right now.
1519615196
if (FlagUser->getOpcode() == PPCISD::MFOCRF)
15197-
return SDValue(VCMPoNode, 0);
15197+
return SDValue(VCMPrecNode, 0);
1519815198
}
1519915199
break;
1520015200
case ISD::BRCOND: {
@@ -15283,7 +15283,7 @@ SDValue PPCTargetLowering::PerformDAGCombine(SDNode *N,
1528315283
DAG.getConstant(CompareOpc, dl, MVT::i32)
1528415284
};
1528515285
EVT VTs[] = { LHS.getOperand(2).getValueType(), MVT::Glue };
15286-
SDValue CompNode = DAG.getNode(PPCISD::VCMPo, dl, VTs, Ops);
15286+
SDValue CompNode = DAG.getNode(PPCISD::VCMP_rec, dl, VTs, Ops);
1528715287

1528815288
// Unpack the result based on how the target uses it.
1528915289
PPC::Predicate CompOpc;

llvm/lib/Target/PowerPC/PPCISelLowering.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -265,11 +265,11 @@ namespace llvm {
265265
/// is VCMPGTSH.
266266
VCMP,
267267

268-
/// RESVEC, OUTFLAG = VCMPo(LHS, RHS, OPC) - Represents one of the
269-
/// altivec VCMP*o instructions. For lack of better number, we use the
268+
/// RESVEC, OUTFLAG = VCMP_rec(LHS, RHS, OPC) - Represents one of the
269+
/// altivec VCMP*_rec instructions. For lack of better number, we use the
270270
/// opcode number encoding for the OPC field to identify the compare. For
271271
/// example, 838 is VCMPGTSH.
272-
VCMPo,
272+
VCMP_rec,
273273

274274
/// CHAIN = COND_BRANCH CHAIN, CRRC, OPC, DESTBB [, INFLAG] - This
275275
/// corresponds to the COND_BRANCH pseudo instruction. CRRC is the

llvm/lib/Target/PowerPC/PPCInstrAltivec.td

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -784,47 +784,47 @@ class VCMP<bits<10> xo, string asmstr, ValueType Ty>
784784
: VXRForm_1<xo, (outs vrrc:$vD), (ins vrrc:$vA, vrrc:$vB), asmstr,
785785
IIC_VecFPCompare,
786786
[(set Ty:$vD, (Ty (PPCvcmp Ty:$vA, Ty:$vB, xo)))]>;
787-
class VCMPo<bits<10> xo, string asmstr, ValueType Ty>
787+
class VCMP_rec<bits<10> xo, string asmstr, ValueType Ty>
788788
: VXRForm_1<xo, (outs vrrc:$vD), (ins vrrc:$vA, vrrc:$vB), asmstr,
789789
IIC_VecFPCompare,
790-
[(set Ty:$vD, (Ty (PPCvcmp_o Ty:$vA, Ty:$vB, xo)))]> {
790+
[(set Ty:$vD, (Ty (PPCvcmp_rec Ty:$vA, Ty:$vB, xo)))]> {
791791
let Defs = [CR6];
792792
let RC = 1;
793793
}
794794

795795
// f32 element comparisons.0
796796
def VCMPBFP : VCMP <966, "vcmpbfp $vD, $vA, $vB" , v4f32>;
797-
def VCMPBFP_rec : VCMPo<966, "vcmpbfp. $vD, $vA, $vB" , v4f32>;
797+
def VCMPBFP_rec : VCMP_rec<966, "vcmpbfp. $vD, $vA, $vB" , v4f32>;
798798
def VCMPEQFP : VCMP <198, "vcmpeqfp $vD, $vA, $vB" , v4f32>;
799-
def VCMPEQFP_rec : VCMPo<198, "vcmpeqfp. $vD, $vA, $vB", v4f32>;
799+
def VCMPEQFP_rec : VCMP_rec<198, "vcmpeqfp. $vD, $vA, $vB", v4f32>;
800800
def VCMPGEFP : VCMP <454, "vcmpgefp $vD, $vA, $vB" , v4f32>;
801-
def VCMPGEFP_rec : VCMPo<454, "vcmpgefp. $vD, $vA, $vB", v4f32>;
801+
def VCMPGEFP_rec : VCMP_rec<454, "vcmpgefp. $vD, $vA, $vB", v4f32>;
802802
def VCMPGTFP : VCMP <710, "vcmpgtfp $vD, $vA, $vB" , v4f32>;
803-
def VCMPGTFP_rec : VCMPo<710, "vcmpgtfp. $vD, $vA, $vB", v4f32>;
803+
def VCMPGTFP_rec : VCMP_rec<710, "vcmpgtfp. $vD, $vA, $vB", v4f32>;
804804

805805
// i8 element comparisons.
806806
def VCMPEQUB : VCMP < 6, "vcmpequb $vD, $vA, $vB" , v16i8>;
807-
def VCMPEQUB_rec : VCMPo< 6, "vcmpequb. $vD, $vA, $vB", v16i8>;
807+
def VCMPEQUB_rec : VCMP_rec< 6, "vcmpequb. $vD, $vA, $vB", v16i8>;
808808
def VCMPGTSB : VCMP <774, "vcmpgtsb $vD, $vA, $vB" , v16i8>;
809-
def VCMPGTSB_rec : VCMPo<774, "vcmpgtsb. $vD, $vA, $vB", v16i8>;
809+
def VCMPGTSB_rec : VCMP_rec<774, "vcmpgtsb. $vD, $vA, $vB", v16i8>;
810810
def VCMPGTUB : VCMP <518, "vcmpgtub $vD, $vA, $vB" , v16i8>;
811-
def VCMPGTUB_rec : VCMPo<518, "vcmpgtub. $vD, $vA, $vB", v16i8>;
811+
def VCMPGTUB_rec : VCMP_rec<518, "vcmpgtub. $vD, $vA, $vB", v16i8>;
812812

813813
// i16 element comparisons.
814814
def VCMPEQUH : VCMP < 70, "vcmpequh $vD, $vA, $vB" , v8i16>;
815-
def VCMPEQUH_rec : VCMPo< 70, "vcmpequh. $vD, $vA, $vB", v8i16>;
815+
def VCMPEQUH_rec : VCMP_rec< 70, "vcmpequh. $vD, $vA, $vB", v8i16>;
816816
def VCMPGTSH : VCMP <838, "vcmpgtsh $vD, $vA, $vB" , v8i16>;
817-
def VCMPGTSH_rec : VCMPo<838, "vcmpgtsh. $vD, $vA, $vB", v8i16>;
817+
def VCMPGTSH_rec : VCMP_rec<838, "vcmpgtsh. $vD, $vA, $vB", v8i16>;
818818
def VCMPGTUH : VCMP <582, "vcmpgtuh $vD, $vA, $vB" , v8i16>;
819-
def VCMPGTUH_rec : VCMPo<582, "vcmpgtuh. $vD, $vA, $vB", v8i16>;
819+
def VCMPGTUH_rec : VCMP_rec<582, "vcmpgtuh. $vD, $vA, $vB", v8i16>;
820820

821821
// i32 element comparisons.
822822
def VCMPEQUW : VCMP <134, "vcmpequw $vD, $vA, $vB" , v4i32>;
823-
def VCMPEQUW_rec : VCMPo<134, "vcmpequw. $vD, $vA, $vB", v4i32>;
823+
def VCMPEQUW_rec : VCMP_rec<134, "vcmpequw. $vD, $vA, $vB", v4i32>;
824824
def VCMPGTSW : VCMP <902, "vcmpgtsw $vD, $vA, $vB" , v4i32>;
825-
def VCMPGTSW_rec : VCMPo<902, "vcmpgtsw. $vD, $vA, $vB", v4i32>;
825+
def VCMPGTSW_rec : VCMP_rec<902, "vcmpgtsw. $vD, $vA, $vB", v4i32>;
826826
def VCMPGTUW : VCMP <646, "vcmpgtuw $vD, $vA, $vB" , v4i32>;
827-
def VCMPGTUW_rec : VCMPo<646, "vcmpgtuw. $vD, $vA, $vB", v4i32>;
827+
def VCMPGTUW_rec : VCMP_rec<646, "vcmpgtuw. $vD, $vA, $vB", v4i32>;
828828

829829
let isCodeGenOnly = 1, isMoveImm = 1, isAsCheapAsAMove = 1,
830830
isReMaterializable = 1 in {
@@ -1291,11 +1291,11 @@ def VORC : VXForm_1<1348, (outs vrrc:$vD), (ins vrrc:$vA, vrrc:$vB),
12911291

12921292
// i64 element comparisons.
12931293
def VCMPEQUD : VCMP <199, "vcmpequd $vD, $vA, $vB" , v2i64>;
1294-
def VCMPEQUD_rec : VCMPo<199, "vcmpequd. $vD, $vA, $vB", v2i64>;
1294+
def VCMPEQUD_rec : VCMP_rec<199, "vcmpequd. $vD, $vA, $vB", v2i64>;
12951295
def VCMPGTSD : VCMP <967, "vcmpgtsd $vD, $vA, $vB" , v2i64>;
1296-
def VCMPGTSD_rec : VCMPo<967, "vcmpgtsd. $vD, $vA, $vB", v2i64>;
1296+
def VCMPGTSD_rec : VCMP_rec<967, "vcmpgtsd. $vD, $vA, $vB", v2i64>;
12971297
def VCMPGTUD : VCMP <711, "vcmpgtud $vD, $vA, $vB" , v2i64>;
1298-
def VCMPGTUD_rec : VCMPo<711, "vcmpgtud. $vD, $vA, $vB", v2i64>;
1298+
def VCMPGTUD_rec : VCMP_rec<711, "vcmpgtud. $vD, $vA, $vB", v2i64>;
12991299

13001300
// The cryptography instructions that do not require Category:Vector.Crypto
13011301
def VPMSUMB : VX1_Int_Ty<1032, "vpmsumb",
@@ -1363,21 +1363,21 @@ def VMSUMUDM : VA1a_Int_Ty3<35, "vmsumudm", int_ppc_altivec_vmsumudm,
13631363

13641364
// i8 element comparisons.
13651365
def VCMPNEB : VCMP < 7, "vcmpneb $vD, $vA, $vB" , v16i8>;
1366-
def VCMPNEB_rec : VCMPo < 7, "vcmpneb. $vD, $vA, $vB" , v16i8>;
1366+
def VCMPNEB_rec : VCMP_rec < 7, "vcmpneb. $vD, $vA, $vB" , v16i8>;
13671367
def VCMPNEZB : VCMP <263, "vcmpnezb $vD, $vA, $vB" , v16i8>;
1368-
def VCMPNEZB_rec : VCMPo<263, "vcmpnezb. $vD, $vA, $vB", v16i8>;
1368+
def VCMPNEZB_rec : VCMP_rec<263, "vcmpnezb. $vD, $vA, $vB", v16i8>;
13691369

13701370
// i16 element comparisons.
13711371
def VCMPNEH : VCMP < 71, "vcmpneh $vD, $vA, $vB" , v8i16>;
1372-
def VCMPNEH_rec : VCMPo< 71, "vcmpneh. $vD, $vA, $vB" , v8i16>;
1372+
def VCMPNEH_rec : VCMP_rec< 71, "vcmpneh. $vD, $vA, $vB" , v8i16>;
13731373
def VCMPNEZH : VCMP <327, "vcmpnezh $vD, $vA, $vB" , v8i16>;
1374-
def VCMPNEZH_rec : VCMPo<327, "vcmpnezh. $vD, $vA, $vB", v8i16>;
1374+
def VCMPNEZH_rec : VCMP_rec<327, "vcmpnezh. $vD, $vA, $vB", v8i16>;
13751375

13761376
// i32 element comparisons.
13771377
def VCMPNEW : VCMP <135, "vcmpnew $vD, $vA, $vB" , v4i32>;
1378-
def VCMPNEW_rec : VCMPo<135, "vcmpnew. $vD, $vA, $vB" , v4i32>;
1378+
def VCMPNEW_rec : VCMP_rec<135, "vcmpnew. $vD, $vA, $vB" , v4i32>;
13791379
def VCMPNEZW : VCMP <391, "vcmpnezw $vD, $vA, $vB" , v4i32>;
1380-
def VCMPNEZW_rec : VCMPo<391, "vcmpnezw. $vD, $vA, $vB", v4i32>;
1380+
def VCMPNEZW_rec : VCMP_rec<391, "vcmpnezw. $vD, $vA, $vB", v4i32>;
13811381

13821382
// VX-Form: [PO VRT / UIM VRB XO].
13831383
// We use VXForm_1 to implement it, that is, we use "VRA" (5 bit) to represent

llvm/lib/Target/PowerPC/PPCInstrInfo.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,7 @@ def PPCrfebb : SDNode<"PPCISD::RFEBB", SDT_PPCsc,
335335
[SDNPHasChain, SDNPSideEffect]>;
336336

337337
def PPCvcmp : SDNode<"PPCISD::VCMP" , SDT_PPCvcmp, []>;
338-
def PPCvcmp_o : SDNode<"PPCISD::VCMPo", SDT_PPCvcmp, [SDNPOutGlue]>;
338+
def PPCvcmp_rec : SDNode<"PPCISD::VCMP_rec", SDT_PPCvcmp, [SDNPOutGlue]>;
339339

340340
def PPCcondbranch : SDNode<"PPCISD::COND_BRANCH", SDT_PPCcondbr,
341341
[SDNPHasChain, SDNPOptInGlue]>;

llvm/lib/Target/PowerPC/PPCInstrPrefix.td

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2316,9 +2316,9 @@ let Predicates = [IsISA3_1] in {
23162316
def VCMPEQUQ : VCMP <455, "vcmpequq $vD, $vA, $vB" , v1i128>;
23172317
def VCMPGTSQ : VCMP <903, "vcmpgtsq $vD, $vA, $vB" , v1i128>;
23182318
def VCMPGTUQ : VCMP <647, "vcmpgtuq $vD, $vA, $vB" , v1i128>;
2319-
def VCMPEQUQ_rec : VCMPo <455, "vcmpequq. $vD, $vA, $vB" , v1i128>;
2320-
def VCMPGTSQ_rec : VCMPo <903, "vcmpgtsq. $vD, $vA, $vB" , v1i128>;
2321-
def VCMPGTUQ_rec : VCMPo <647, "vcmpgtuq. $vD, $vA, $vB" , v1i128>;
2319+
def VCMPEQUQ_rec : VCMP_rec <455, "vcmpequq. $vD, $vA, $vB" , v1i128>;
2320+
def VCMPGTSQ_rec : VCMP_rec <903, "vcmpgtsq. $vD, $vA, $vB" , v1i128>;
2321+
def VCMPGTUQ_rec : VCMP_rec <647, "vcmpgtuq. $vD, $vA, $vB" , v1i128>;
23222322
def VMODSQ : VXForm_1<1803, (outs vrrc:$vD), (ins vrrc:$vA, vrrc:$vB),
23232323
"vmodsq $vD, $vA, $vB", IIC_VecGeneral,
23242324
[(set v1i128:$vD, (srem v1i128:$vA, v1i128:$vB))]>;

llvm/lib/Target/PowerPC/PPCInstrVSX.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ multiclass XX3Form_Rcr<bits<6> opcode, bits<7> xo, string asmbase,
167167
def _rec : XX3Form_Rc<opcode, xo, (outs vsrc:$XT), (ins vsrc:$XA, vsrc:$XB),
168168
!strconcat(asmbase, !strconcat(". ", asmstr)), itin,
169169
[(set InTy:$XT,
170-
(InTy (PPCvcmp_o InTy:$XA, InTy:$XB, xo)))]>,
170+
(InTy (PPCvcmp_rec InTy:$XA, InTy:$XB, xo)))]>,
171171
isRecordForm;
172172
}
173173
}

0 commit comments

Comments
 (0)