Skip to content

Commit 3334b9d

Browse files
committed
[ELF][test] Enhance relative dynamic relocation tests
Add checking of the value of the relocation with an addend. Also check all relocation offsets. Differential Revision: https://reviews.llvm.org/D111071
1 parent 8ed0e6b commit 3334b9d

File tree

2 files changed

+11
-9
lines changed

2 files changed

+11
-9
lines changed

lld/test/ELF/relative-dynamic-reloc-pie.s

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,10 @@
66
## Test that we create R_X86_64_RELATIVE relocations with -pie.
77
# CHECK: Relocations [
88
# CHECK-NEXT: Section ({{.*}}) .rela.dyn {
9-
# CHECK-NEXT: 0x3368 R_X86_64_RELATIVE - 0x3368
10-
# CHECK-NEXT: 0x3370 R_X86_64_RELATIVE - 0x3370
11-
# CHECK-NEXT: 0x3378 R_X86_64_RELATIVE - 0x3371
9+
# CHECK-NEXT: 0x[[FOO_ADDR:.*]] R_X86_64_RELATIVE - 0x[[FOO_ADDR]]
10+
# CHECK-NEXT: 0x[[#%X,BAR_ADDR:]] R_X86_64_RELATIVE
11+
# CHECK-SAME: - 0x[[#BAR_ADDR]]
12+
# CHECK-NEXT: 0x[[#BAR_ADDR + 8]] R_X86_64_RELATIVE - 0x[[#BAR_ADDR + 1]]
1213
# CHECK-NEXT: }
1314
# CHECK-NEXT: ]
1415

lld/test/ELF/relative-dynamic-reloc.s

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,19 +9,20 @@
99
// CHECK: Relocations [
1010
// CHECK-NEXT: Section ({{.*}}) .rela.dyn {
1111
// CHECK-NEXT: 0x[[FOO_ADDR:.*]] R_X86_64_RELATIVE - 0x[[FOO_ADDR]]
12-
// CHECK-NEXT: 0x[[BAR_ADDR:.*]] R_X86_64_RELATIVE - 0x[[BAR_ADDR]]
13-
// CHECK-NEXT: 0x{{[0-9A-F]+}} R_X86_64_RELATIVE - 0x{{[0-9A-F]+}}
14-
// CHECK-NEXT: 0x{{.*}} R_X86_64_RELATIVE - 0x[[ZED_ADDR:.*]]
15-
// CHECK-NEXT: 0x{{.*}} R_X86_64_RELATIVE - 0x[[FOO_ADDR]]
16-
// CHECK-NEXT: 0x{{[0-9A-F]+}} R_X86_64_64 external 0x0
12+
// CHECK-NEXT: 0x[[#%X,BAR_ADDR:]] R_X86_64_RELATIVE
13+
// CHECK-SAME: - 0x[[#BAR_ADDR]]
14+
// CHECK-NEXT: 0x[[#BAR_ADDR + 8]] R_X86_64_RELATIVE - 0x[[#BAR_ADDR + 1]]
15+
// CHECK-NEXT: 0x[[#BAR_ADDR + 16]] R_X86_64_RELATIVE - 0x[[ZED_ADDR:.*]]
16+
// CHECK-NEXT: 0x[[#BAR_ADDR + 24]] R_X86_64_RELATIVE - 0x[[FOO_ADDR]]
17+
// CHECK-NEXT: 0x[[#BAR_ADDR + 32]] R_X86_64_64 external 0x0
1718
// CHECK-NEXT: }
1819
// CHECK-NEXT: ]
1920

2021
// CHECK: Symbols [
2122
// CHECK: Name: foo
2223
// CHECK-NEXT: Value: 0x[[FOO_ADDR]]
2324
// CHECK: Name: bar
24-
// CHECK-NEXT: Value: 0x[[BAR_ADDR]]
25+
// CHECK-NEXT: Value: 0x[[#BAR_ADDR]]
2526
// CHECK: Name: zed
2627
// CHECK-NEXT: Value: 0x[[ZED_ADDR]]
2728
// CHECK: ]

0 commit comments

Comments
 (0)