Change the return type of UpgradeARCRuntimeCalls to void

Nothing is using the function return.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@368367 91177308-0d34-0410-b5e6-96231b3b80d8
(cherry picked from commit 33c8afb)

apple-llvm-split-commit: 1c6215dea3c808404e055e6296833402fa2345d7
apple-llvm-split-dir: llvm/

Author: ahatanaka

llvm/include/llvm/IR/AutoUpgrade.h

@@ -61,7 +61,7 @@ namespace llvm {
 
   /// Convert calls to ARC runtime functions to intrinsic calls if the bitcode
   /// has the arm64 retainAutoreleasedReturnValue marker.
-  bool UpgradeARCRuntimeCalls(Module &M);
+  void UpgradeARCRuntimeCalls(Module &M);
 
   void UpgradeSectionAttributes(Module &M);
 

llvm/lib/IR/AutoUpgrade.cpp

@@ -3653,28 +3653,26 @@ bool llvm::UpgradeRetainReleaseMarker(Module &M) {
   return Changed;
 }
 
-bool llvm::UpgradeARCRuntimeCalls(Module &M) {
+void llvm::UpgradeARCRuntimeCalls(Module &M) {
   auto UpgradeToIntrinsic = [&](const char *OldFunc,
                                 llvm::Intrinsic::ID IntrinsicFunc) {
     Function *Fn = M.getFunction(OldFunc);
 
     if (!Fn)
-      return false;
+      return;
 
     Function *NewFn = llvm::Intrinsic::getDeclaration(&M, IntrinsicFunc);
     Fn->replaceAllUsesWith(NewFn);
     Fn->eraseFromParent();
-    return true;
   };
 
   // Unconditionally convert "clang.arc.use" to "llvm.objc.clang.arc.use".
-  bool Changed =
-      UpgradeToIntrinsic("clang.arc.use", llvm::Intrinsic::objc_clang_arc_use);
+  UpgradeToIntrinsic("clang.arc.use", llvm::Intrinsic::objc_clang_arc_use);
 
   // Return if the bitcode doesn't have the arm64 retainAutoreleasedReturnValue
   // marker. We don't know for sure that it was compiled with ARC in that case.
   if (!M.getModuleFlag("clang.arc.retainAutoreleasedReturnValueMarker"))
-    return false;
+    return;
 
   std::pair<const char *, llvm::Intrinsic::ID> RuntimeFuncs[] = {
       {"objc_autorelease", llvm::Intrinsic::objc_autorelease},
@@ -3716,9 +3714,7 @@ bool llvm::UpgradeARCRuntimeCalls(Module &M) {
        llvm::Intrinsic::objc_arc_annotation_bottomup_bbend}};
 
   for (auto &I : RuntimeFuncs)
-    Changed |= UpgradeToIntrinsic(I.first, I.second);
-
-  return Changed;
+    UpgradeToIntrinsic(I.first, I.second);
 }
 
 bool llvm::UpgradeModuleFlags(Module &M) {