Merge pull request #9465 from augusto2112/comment-enum-case

adrian-prantl · web-flow · commit 40563ea134d7 · 2024-10-25T11:26:51.000-07:00
[lldb] Comment assert in GetEnumCaseName
diff --git a/lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeDynamicTypeResolution.cpp b/lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeDynamicTypeResolution.cpp
@@ -970,7 +970,8 @@ std::optional<std::string> SwiftLanguageRuntimeImpl::GetEnumCaseName(
   if (eti->projectEnumValue(*GetMemoryReader(), addr, &case_index))
     return eti->getCases()[case_index].Name;
 
-  LogUnimplementedTypeKind(__FUNCTION__, type);
+  // TODO: uncomment this after fixing projection for every type: rdar://138424904
+  // LogUnimplementedTypeKind(__FUNCTION__, type);
   return {};
 }
 

Original file line number	Diff line number	Diff line change
`@@ -970,7 +970,8 @@ std::optional<std::string> SwiftLanguageRuntimeImpl::GetEnumCaseName(`
`970`	`970`	`if (eti->projectEnumValue(*GetMemoryReader(), addr, &case_index))`
`971`	`971`	`return eti->getCases()[case_index].Name;`
`972`	`972`
`973`		`- LogUnimplementedTypeKind(__FUNCTION__, type);`
	`973`	`+ // TODO: uncomment this after fixing projection for every type: rdar://138424904`
	`974`	`+ // LogUnimplementedTypeKind(__FUNCTION__, type);`
`974`	`975`	`return {};`
`975`	`976`	`}`
`976`	`977`