[clang][deps] Reset non-modular language and preprocessor options

There are a number of language and preprocessor options that are reset in the `CompilerInvocation` that describes the build of an implicit module. This patch uses the logic for explicit modules as well.

Reviewed By: dexonsmith

Differential Revision: https://reviews.llvm.org/D108710

Author: jansvoboda11

clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp

@@ -23,6 +23,9 @@ CompilerInvocation ModuleDepCollector::makeInvocationForModuleBuildWithoutPaths(
   // Make a deep copy of the original Clang invocation.
   CompilerInvocation CI(OriginalInvocation);
 
+  CI.getLangOpts()->resetNonModularOptions();
+  CI.getPreprocessorOpts().resetNonModularOptions();
+
   // Remove options incompatible with explicit module build.
   CI.getFrontendOpts().Inputs.clear();
   CI.getFrontendOpts().OutputFile.clear();
@@ -39,8 +42,6 @@ CompilerInvocation ModuleDepCollector::makeInvocationForModuleBuildWithoutPaths(
     CI.getFrontendOpts().ModuleMapFiles.push_back(PrebuiltModule.ModuleMapFile);
   }
 
-  CI.getPreprocessorOpts().ImplicitPCHInclude.clear();
-
   return CI;
 }
 

clang/test/ClangScanDeps/Inputs/removed-args/cdb.json.template

@@ -0,0 +1,7 @@
+[
+  {
+    "directory": "DIR",
+    "command": "clang -fsyntax-only DIR/tu.c -fmodules -fimplicit-module-maps -fmodules-cache-path=DIR/cache -include DIR/header.h -o DIR/tu.o",
+    "file": "DIR/tu.c"
+  }
+]

clang/test/ClangScanDeps/Inputs/removed-args/header.h

@@ -0,0 +1 @@
+#include "mod_header.h"

clang/test/ClangScanDeps/Inputs/removed-args/mod_header.h

@@ -0,0 +1,2 @@
+module ModHeader { header "mod_header.h" }
+module ModTU     { header "mod_tu.h"     }

clang/test/ClangScanDeps/Inputs/removed-args/mod_tu.h

@@ -0,0 +1 @@
+#include "mod_tu.h"

clang/test/ClangScanDeps/Inputs/removed-args/module.modulemap

@@ -0,0 +1,60 @@
+// Some command-line arguments used for compiling translation units are not
+// compatible with the semantics of modules and should be removed. In this test
+// case, the command-lines for modules should drop the '-include' argument.
+
+// RUN: rm -rf %t && mkdir %t
+// RUN: cp %S/Inputs/removed-args/* %t
+
+// RUN: sed "s|DIR|%/t|g" %S/Inputs/removed-args/cdb.json.template > %t/cdb.json
+// RUN: echo -%t > %t/result.json
+// RUN: clang-scan-deps -compilation-database %t/cdb.json -format experimental-full >> %t/result.json
+// RUN: cat %t/result.json | sed 's:\\\\\?:/:g' | FileCheck %s
+//
+// CHECK:      -[[PREFIX:.*]]
+// CHECK-NEXT: {
+// CHECK-NEXT:   "modules": [
+// CHECK-NEXT:     {
+// CHECK-NEXT:       "clang-module-deps": [],
+// CHECK-NEXT:       "clang-modulemap-file": "[[PREFIX]]/module.modulemap",
+// CHECK-NEXT:       "command-line": [
+// CHECK-NEXT:         "-cc1"
+// CHECK-NOT:          "-include"
+// CHECK:            ],
+// CHECK-NEXT:       "context-hash": "[[HASH_MOD_HEADER:.*]]",
+// CHECK-NEXT:       "file-deps": [
+// CHECK-NEXT:         "[[PREFIX]]/mod_header.h",
+// CHECK-NEXT:         "[[PREFIX]]/module.modulemap"
+// CHECK-NEXT:       ],
+// CHECK-NEXT:       "name": "ModHeader"
+// CHECK-NEXT:     },
+// CHECK-NEXT:     {
+// CHECK-NEXT:       "clang-module-deps": [],
+// CHECK-NEXT:       "clang-modulemap-file": "[[PREFIX]]/module.modulemap",
+// CHECK-NEXT:       "command-line": [
+// CHECK-NEXT:         "-cc1"
+// CHECK-NOT:          "-include"
+// CHECK:            ],
+// CHECK-NEXT:       "context-hash": "[[HASH_MOD_TU:.*]]",
+// CHECK-NEXT:       "file-deps": [
+// CHECK-NEXT:         "[[PREFIX]]/mod_tu.h",
+// CHECK-NEXT:         "[[PREFIX]]/module.modulemap"
+// CHECK-NEXT:       ],
+// CHECK-NEXT:       "name": "ModTU"
+// CHECK-NEXT:     }
+// CHECK-NEXT:   ],
+// CHECK-NEXT:   "translation-units": [
+// CHECK-NEXT:     {
+// CHECK-NEXT:       "clang-context-hash": "[[HASH_TU:.*]]",
+// CHECK-NEXT:       "clang-module-deps": [
+// CHECK-NEXT:         {
+// CHECK-NEXT:           "context-hash": "[[HASH_MOD_HEADER]]",
+// CHECK-NEXT:           "module-name": "ModHeader"
+// CHECK-NEXT:         },
+// CHECK-NEXT:         {
+// CHECK-NEXT:           "context-hash": "[[HASH_MOD_TU]]",
+// CHECK-NEXT:           "module-name": "ModTU"
+// CHECK-NEXT:         }
+// CHECK-NEXT:       ]
+// CHECK:          }
+// CHECK-NEXT:   ]
+// CHECK-NEXT: }