Skip to content

Commit 41e22aa

Browse files
authored
[Offload] Set size correctly in olLaunchKernel cts test (llvm#142398)
It was previously not scaled by `sizeof(uint32_t)`.
1 parent c5da471 commit 41e22aa

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
#include <gpuintrin.h>
2+
#include <stdint.h>
23

3-
__gpu_kernel void foo(int *out) {
4+
__gpu_kernel void foo(uint32_t *out) {
45
out[__gpu_thread_id(0)] = __gpu_thread_id(0);
56
}

offload/unittests/OffloadAPI/kernel/olLaunchKernel.cpp

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,8 @@ OFFLOAD_TESTS_INSTANTIATE_DEVICE_FIXTURE(olLaunchKernelTest);
4747

4848
TEST_P(olLaunchKernelTest, Success) {
4949
void *Mem;
50-
ASSERT_SUCCESS(olMemAlloc(Device, OL_ALLOC_TYPE_MANAGED, 64, &Mem));
50+
ASSERT_SUCCESS(olMemAlloc(Device, OL_ALLOC_TYPE_MANAGED,
51+
LaunchArgs.GroupSizeX * sizeof(uint32_t), &Mem));
5152
struct {
5253
void *Mem;
5354
} Args{Mem};
@@ -57,7 +58,7 @@ TEST_P(olLaunchKernelTest, Success) {
5758

5859
ASSERT_SUCCESS(olWaitQueue(Queue));
5960

60-
int *Data = (int *)Mem;
61+
uint32_t *Data = (uint32_t *)Mem;
6162
for (int i = 0; i < 64; i++) {
6263
ASSERT_EQ(Data[i], i);
6364
}
@@ -67,7 +68,8 @@ TEST_P(olLaunchKernelTest, Success) {
6768

6869
TEST_P(olLaunchKernelTest, SuccessSynchronous) {
6970
void *Mem;
70-
ASSERT_SUCCESS(olMemAlloc(Device, OL_ALLOC_TYPE_MANAGED, 64, &Mem));
71+
ASSERT_SUCCESS(olMemAlloc(Device, OL_ALLOC_TYPE_MANAGED,
72+
LaunchArgs.GroupSizeX * sizeof(uint32_t), &Mem));
7173

7274
struct {
7375
void *Mem;
@@ -76,7 +78,7 @@ TEST_P(olLaunchKernelTest, SuccessSynchronous) {
7678
ASSERT_SUCCESS(olLaunchKernel(nullptr, Device, Kernel, &Args, sizeof(Args),
7779
&LaunchArgs, nullptr));
7880

79-
int *Data = (int *)Mem;
81+
uint32_t *Data = (uint32_t *)Mem;
8082
for (int i = 0; i < 64; i++) {
8183
ASSERT_EQ(Data[i], i);
8284
}

0 commit comments

Comments
 (0)