Skip to content

Commit 4acc2f2

Browse files
committed
[OpenMP][Tools][Tests][NFC] Address flaky archer tests
Adding more concurrent threads significantly increases the chance that the data race can be observed during testing.
1 parent 95ef464 commit 4acc2f2

File tree

8 files changed

+8
-8
lines changed

8 files changed

+8
-8
lines changed

openmp/tools/archer/tests/races/critical-unrelated.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
int main(int argc, char *argv[]) {
2020
int var = 0;
2121

22-
#pragma omp parallel num_threads(2) shared(var)
22+
#pragma omp parallel num_threads(8) shared(var)
2323
{
2424
#pragma omp critical
2525
{

openmp/tools/archer/tests/races/lock-nested-unrelated.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ int main(int argc, char *argv[]) {
2222
omp_nest_lock_t lock;
2323
omp_init_nest_lock(&lock);
2424

25-
#pragma omp parallel num_threads(2) shared(var)
25+
#pragma omp parallel num_threads(8) shared(var)
2626
{
2727
omp_set_nest_lock(&lock);
2828
omp_set_nest_lock(&lock);

openmp/tools/archer/tests/races/lock-unrelated.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ int main(int argc, char *argv[]) {
2222
omp_lock_t lock;
2323
omp_init_lock(&lock);
2424

25-
#pragma omp parallel num_threads(2) shared(var)
25+
#pragma omp parallel num_threads(8) shared(var)
2626
{
2727
omp_set_lock(&lock);
2828
// Dummy locking.

openmp/tools/archer/tests/races/parallel-simple.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
int main(int argc, char *argv[]) {
2020
int var = 0;
2121

22-
#pragma omp parallel num_threads(2) shared(var)
22+
#pragma omp parallel num_threads(8) shared(var)
2323
{ var++; }
2424

2525
int error = (var != 2);

openmp/tools/archer/tests/races/task-dependency.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
int main(int argc, char *argv[]) {
2222
int var = 0, a = 0;
2323

24-
#pragma omp parallel num_threads(2) shared(var, a)
24+
#pragma omp parallel num_threads(8) shared(var, a)
2525
#pragma omp master
2626
{
2727
#pragma omp task shared(var, a) depend(out : var)

openmp/tools/archer/tests/races/task-taskgroup-unrelated.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
int main(int argc, char *argv[]) {
2222
int var = 0, a = 0;
2323

24-
#pragma omp parallel num_threads(2) shared(var, a)
24+
#pragma omp parallel num_threads(8) shared(var, a)
2525
#pragma omp master
2626
{
2727
#pragma omp task shared(var, a)

openmp/tools/archer/tests/races/task-taskwait-nested.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
int main(int argc, char *argv[]) {
2222
int var = 0, a = 0;
2323

24-
#pragma omp parallel num_threads(2) shared(var, a)
24+
#pragma omp parallel num_threads(8) shared(var, a)
2525
#pragma omp master
2626
{
2727
#pragma omp task shared(var, a)

openmp/tools/archer/tests/races/task-two.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
#include <stdio.h>
1818
#include <unistd.h>
1919

20-
#define NUM_THREADS 2
20+
#define NUM_THREADS 8
2121

2222
int main(int argc, char *argv[]) {
2323
int var = 0;

0 commit comments

Comments
 (0)