Skip to content

Commit 4cbed7a

Browse files
committed
[lldb] Set the Swift RPATH for both build and install
1 parent 1b62ca7 commit 4cbed7a

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

lldb/cmake/modules/AddLLDB.cmake

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -161,12 +161,10 @@ function(add_properties_for_swift_modules target)
161161
target_link_directories(${target} PRIVATE
162162
"${CMAKE_OSX_SYSROOT}/usr/lib/swift"
163163
"${LLDB_SWIFT_LIBS}/macosx")
164-
set_property(TARGET ${target} APPEND PROPERTY INSTALL_RPATH
165-
"/usr/lib/swift")
164+
set(SWIFT_RPATH "/usr/lib/swift")
166165
elseif(BOOTSTRAPPING_MODE STREQUAL "BOOTSTRAPPING")
167166
target_link_directories(${target} PRIVATE "${LLDB_SWIFT_LIBS}/macosx")
168-
set_property(TARGET ${target} APPEND PROPERTY INSTALL_RPATH
169-
"${LLDB_SWIFT_LIBS}/macosx")
167+
set(SWIFT_RPATH "${LLDB_SWIFT_LIBS}/macosx")
170168
else()
171169
message(FATAL_ERROR "Unknown BOOTSTRAPPING_MODE '${BOOTSTRAPPING_MODE}'")
172170
endif()
@@ -177,12 +175,11 @@ function(add_properties_for_swift_modules target)
177175
elseif (CMAKE_SYSTEM_NAME MATCHES "Linux")
178176
string(REGEX MATCH "^[^-]*" arch ${LLVM_TARGET_TRIPLE})
179177
target_link_libraries(${target} PRIVATE swiftCore-linux-${arch})
180-
181-
# TODO: add "${LLDB_SWIFT_LIBS}/linux" to BUILD_RPATH and not INSTALL_RPATH.
182-
# This does not work for some reason.
183-
set_property(TARGET ${target} APPEND PROPERTY INSTALL_RPATH
184-
"${LLDB_SWIFT_LIBS}/linux;$ORIGIN/../lib/swift/linux")
178+
set(SWIFT_RPATH "${LLDB_SWIFT_LIBS}/linux;$ORIGIN/../lib/swift/linux")
185179
endif()
180+
181+
set_property(TARGET ${target} APPEND PROPERTY BUILD_RPATH "${SWIFT_RPATH}")
182+
set_property(TARGET ${target} APPEND PROPERTY INSTALL_RPATH "${SWIFT_RPATH}")
186183
endif()
187184
endfunction()
188185
# END Swift Mods

0 commit comments

Comments
 (0)