Skip to content

Commit 538df1d

Browse files
committed
lldb [NFC] Add logging to Process when address masks are updated
To aid in integration testing/debugging. Verifying that the address mask/addressable bits values from different sources are correctly registered by lldb.
1 parent 43687da commit 538df1d

File tree

2 files changed

+32
-14
lines changed

2 files changed

+32
-14
lines changed

lldb/include/lldb/Target/Process.h

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1376,21 +1376,11 @@ class Process : public std::enable_shared_from_this<Process>,
13761376
lldb::addr_t GetHighmemCodeAddressMask();
13771377
lldb::addr_t GetHighmemDataAddressMask();
13781378

1379-
void SetCodeAddressMask(lldb::addr_t code_address_mask) {
1380-
m_code_address_mask = code_address_mask;
1381-
}
1382-
1383-
void SetDataAddressMask(lldb::addr_t data_address_mask) {
1384-
m_data_address_mask = data_address_mask;
1385-
}
1379+
void SetCodeAddressMask(lldb::addr_t code_address_mask);
1380+
void SetDataAddressMask(lldb::addr_t data_address_mask);
13861381

1387-
void SetHighmemCodeAddressMask(lldb::addr_t code_address_mask) {
1388-
m_highmem_code_address_mask = code_address_mask;
1389-
}
1390-
1391-
void SetHighmemDataAddressMask(lldb::addr_t data_address_mask) {
1392-
m_highmem_data_address_mask = data_address_mask;
1393-
}
1382+
void SetHighmemCodeAddressMask(lldb::addr_t code_address_mask);
1383+
void SetHighmemDataAddressMask(lldb::addr_t data_address_mask);
13941384

13951385
/// Some targets might use bits in a code address to indicate a mode switch,
13961386
/// ARM uses bit zero to signify a code address is thumb, so any ARM ABI

lldb/source/Target/Process.cpp

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5688,6 +5688,34 @@ lldb::addr_t Process::GetHighmemDataAddressMask() {
56885688
return GetDataAddressMask();
56895689
}
56905690

5691+
void Process::SetCodeAddressMask(lldb::addr_t code_address_mask) {
5692+
Log *log = GetLog(LLDBLog::Process);
5693+
LLDB_LOGF(log, "Setting Process code address mask to 0x%" PRIx64,
5694+
code_address_mask);
5695+
m_code_address_mask = code_address_mask;
5696+
}
5697+
5698+
void Process::SetDataAddressMask(lldb::addr_t data_address_mask) {
5699+
Log *log = GetLog(LLDBLog::Process);
5700+
LLDB_LOGF(log, "Setting Process data address mask to 0x%" PRIx64,
5701+
data_address_mask);
5702+
m_data_address_mask = data_address_mask;
5703+
}
5704+
5705+
void Process::SetHighmemCodeAddressMask(lldb::addr_t code_address_mask) {
5706+
Log *log = GetLog(LLDBLog::Process);
5707+
LLDB_LOGF(log, "Setting Process highmem code address mask to 0x%" PRIx64,
5708+
code_address_mask);
5709+
m_highmem_code_address_mask = code_address_mask;
5710+
}
5711+
5712+
void Process::SetHighmemDataAddressMask(lldb::addr_t data_address_mask) {
5713+
Log *log = GetLog(LLDBLog::Process);
5714+
LLDB_LOGF(log, "Setting Process highmem data address mask to 0x%" PRIx64,
5715+
data_address_mask);
5716+
m_highmem_data_address_mask = data_address_mask;
5717+
}
5718+
56915719
addr_t Process::FixCodeAddress(addr_t addr) {
56925720
if (ABISP abi_sp = GetABI())
56935721
addr = abi_sp->FixCodeAddress(addr);

0 commit comments

Comments
 (0)