make CanContainSwiftReflectionData conditional on LLDB_ENABLE_SWIFT

Author: kastiglione

lldb/include/lldb/Symbol/ObjectFile.h

@@ -690,7 +690,11 @@ class ObjectFile : public std::enable_shared_from_this<ObjectFile>,
   virtual llvm::StringRef
   GetReflectionSectionIdentifier(swift::ReflectionSectionKind section);
 
-  virtual bool CanContainSwiftReflectionData(const Section &section);
+#ifdef LLDB_ENABLE_SWIFT
+  virtual bool CanContainSwiftReflectionData(const Section &section) {
+    return false;
+  }
+#endif // LLDB_ENABLE_SWIFT
 
   /// Load binaries listed in a corefile
   ///

lldb/source/Core/Section.cpp

@@ -391,7 +391,11 @@ void Section::SetPermissions(uint32_t permissions) {
 }
 
 bool Section::CanContainSwiftReflectionData() const {
+#ifdef LLDB_ENABLE_SWIFT
   return m_obj_file->CanContainSwiftReflectionData(*this);
+#else
+  return false;
+#endif // LLDB_ENABLE_SWIFT
 }
 
 lldb::offset_t Section::GetSectionData(void *dst, lldb::offset_t dst_len,

lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

@@ -3430,12 +3430,10 @@ llvm::StringRef ObjectFileELF::GetReflectionSectionIdentifier(
 #endif //LLDB_ENABLE_SWIFT
 }
 
-bool ObjectFileELF::CanContainSwiftReflectionData(const Section &section) {
 #ifdef LLDB_ENABLE_SWIFT
+bool ObjectFileELF::CanContainSwiftReflectionData(const Section &section) {
   swift::SwiftObjectFileFormatELF file_format;
   return file_format.sectionContainsReflectionData(
       section.GetName().GetStringRef());
-#else
-  llvm_unreachable("Swift support disabled");
-#endif // LLDB_ENABLE_SWIFT
 }
+#endif // LLDB_ENABLE_SWIFT

lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.h

@@ -396,8 +396,10 @@ class ObjectFileELF : public lldb_private::ObjectFile {
   llvm::StringRef
   GetReflectionSectionIdentifier(swift::ReflectionSectionKind section) override;
 
+#ifdef LLDB_ENABLE_SWIFT
   bool
   CanContainSwiftReflectionData(const lldb_private::Section &section) override;
+#endif // LLDB_ENABLE_SWIFT
 };
 
 #endif // LLDB_SOURCE_PLUGINS_OBJECTFILE_ELF_OBJECTFILEELF_H

lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp

@@ -7019,8 +7019,8 @@ llvm::StringRef ObjectFileMachO::GetReflectionSectionIdentifier(
 #endif //LLDB_ENABLE_SWIFT
 }
 
-bool ObjectFileMachO::CanContainSwiftReflectionData(const Section &section) {
 #ifdef LLDB_ENABLE_SWIFT
+bool ObjectFileMachO::CanContainSwiftReflectionData(const Section &section) {
   swift::SwiftObjectFileFormatMachO file_format;
   if (file_format.sectionContainsReflectionData(
           section.GetName().GetStringRef()))
@@ -7033,10 +7033,8 @@ bool ObjectFileMachO::CanContainSwiftReflectionData(const Section &section) {
     return file_format.sectionContainsReflectionData(segmentSectionName);
   }
   return false;
-#else
-  llvm_unreachable("Swift support disabled");
-#endif // LLDB_ENABLE_SWIFT
 }
+#endif // LLDB_ENABLE_SWIFT
 
 ObjectFileMachO::MachOCorefileAllImageInfos
 ObjectFileMachO::GetCorefileAllImageInfos() {

lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h

@@ -220,8 +220,10 @@ class ObjectFileMachO : public lldb_private::ObjectFile {
   llvm::StringRef
   GetReflectionSectionIdentifier(swift::ReflectionSectionKind section) override;
 
+#ifdef LLDB_ENABLE_SWIFT
   bool
   CanContainSwiftReflectionData(const lldb_private::Section &section) override;
+#endif // LLDB_ENABLE_SWIFT
 
   /// A corefile may include metadata about all of the binaries that were
   /// present in the process when the corefile was taken.  This is only

lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp

@@ -1217,12 +1217,10 @@ llvm::StringRef ObjectFilePECOFF::GetReflectionSectionIdentifier(
 #endif //LLDB_ENABLE_SWIFT
 }
 
-bool ObjectFilePECOFF::CanContainSwiftReflectionData(const Section &section) {
 #ifdef LLDB_ENABLE_SWIFT
+bool ObjectFilePECOFF::CanContainSwiftReflectionData(const Section &section) {
   swift::SwiftObjectFileFormatCOFF file_format;
   return file_format.sectionContainsReflectionData(
       section.GetName().GetStringRef());
-#else
-  llvm_unreachable("Swift support disabled");
-#endif // LLDB_ENABLE_SWIFT
 }
+#endif // LLDB_ENABLE_SWIFT

lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h

@@ -288,8 +288,10 @@ class ObjectFilePECOFF : public lldb_private::ObjectFile {
   llvm::StringRef
   GetReflectionSectionIdentifier(swift::ReflectionSectionKind section) override;
 
+#ifdef LLDB_ENABLE_SWIFT
   bool
   CanContainSwiftReflectionData(const lldb_private::Section &section) override;
+#endif // LLDB_ENABLE_SWIFT
 
   typedef std::vector<section_header_t> SectionHeaderColl;
   typedef SectionHeaderColl::iterator SectionHeaderCollIter;

lldb/source/Symbol/ObjectFile.cpp

@@ -725,9 +725,3 @@ llvm::StringRef ObjectFile::GetReflectionSectionIdentifier(
          "Base class's GetReflectionSectionIdentifier should not be called");
   return "";
 }
-
-bool ObjectFile::CanContainSwiftReflectionData(const Section &section) {
-  assert(false &&
-         "Base class's CanContainSwiftReflectionData should not be called");
-  return false;
-}