Skip to content

Commit 5e83be5

Browse files
committed
[lldb] Re-add nullptr check to IRForTarget::RewriteObjCConstString log statement
The nullptr check here was removed in 4ef50a3 when I replaced (nearly) all log->Print to LLDB_LOG calls (which automatically check for this stuff). But it seems this one call escaped my sed call. Currently working on a test that can cover this code path but we can revert this until I have found one. (cherry picked from commit e2d8aa6) Fixes rdar://65643074
1 parent 801a49e commit 5e83be5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lldb/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -433,7 +433,7 @@ bool IRForTarget::RewriteObjCConstString(llvm::GlobalVariable *ns_str,
433433
m_execution_unit.FindSymbol(g_CFStringCreateWithBytes_str,
434434
missing_weak);
435435
if (CFStringCreateWithBytes_addr == LLDB_INVALID_ADDRESS || missing_weak) {
436-
log->PutCString("Couldn't find CFStringCreateWithBytes in the target");
436+
LLDB_LOG(log, "Couldn't find CFStringCreateWithBytes in the target");
437437

438438
m_error_stream.Printf("Error [IRForTarget]: Rewriting an Objective-C "
439439
"constant string requires "

0 commit comments

Comments
 (0)