Skip to content

Commit 5ed5df4

Browse files
committed
[X86][SLM] Fix uops for PCMPISTR/PCMPISTR instructions
Based off a recent llvm-exegesis capture and what Intel AoM / Agner reports as well.
1 parent 680afaa commit 5ed5df4

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

llvm/lib/Target/X86/X86ScheduleSLM.td

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -430,16 +430,16 @@ defm : X86WriteResPairUnsupported<WritePHAddZ>;
430430

431431
// String instructions.
432432
// Packed Compare Implicit Length Strings, Return Mask
433-
defm : SLMWriteResPair<WritePCmpIStrM, [SLM_FPC_RSV0], 13, [13]>;
433+
defm : SLMWriteResPair<WritePCmpIStrM, [SLM_FPC_RSV0], 13, [13], 5, 1>;
434434

435435
// Packed Compare Explicit Length Strings, Return Mask
436-
defm : SLMWriteResPair<WritePCmpEStrM, [SLM_FPC_RSV0], 17, [17]>;
436+
defm : SLMWriteResPair<WritePCmpEStrM, [SLM_FPC_RSV0], 17, [17], 8, 1>;
437437

438438
// Packed Compare Implicit Length Strings, Return Index
439-
defm : SLMWriteResPair<WritePCmpIStrI, [SLM_FPC_RSV0], 17, [17]>;
439+
defm : SLMWriteResPair<WritePCmpIStrI, [SLM_FPC_RSV0], 17, [17], 6, 1>;
440440

441441
// Packed Compare Explicit Length Strings, Return Index
442-
defm : SLMWriteResPair<WritePCmpEStrI, [SLM_FPC_RSV0], 21, [21]>;
442+
defm : SLMWriteResPair<WritePCmpEStrI, [SLM_FPC_RSV0], 21, [21], 9, 1>;
443443

444444
// MOVMSK Instructions.
445445
def : WriteRes<WriteFMOVMSK, [SLM_FPC_RSV1]> { let Latency = 4; }

llvm/test/tools/llvm-mca/X86/SLM/resources-sse42.s

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -50,14 +50,14 @@ pcmpgtq (%rax), %xmm2
5050
# CHECK-NEXT: 1 6 1.00 * crc32b (%rax), %rcx
5151
# CHECK-NEXT: 1 3 1.00 crc32q %rax, %rcx
5252
# CHECK-NEXT: 1 6 1.00 * crc32q (%rax), %rcx
53-
# CHECK-NEXT: 1 21 21.00 pcmpestri $1, %xmm0, %xmm2
54-
# CHECK-NEXT: 1 24 21.00 * pcmpestri $1, (%rax), %xmm2
55-
# CHECK-NEXT: 1 17 17.00 pcmpestrm $1, %xmm0, %xmm2
56-
# CHECK-NEXT: 1 20 17.00 * pcmpestrm $1, (%rax), %xmm2
57-
# CHECK-NEXT: 1 17 17.00 pcmpistri $1, %xmm0, %xmm2
58-
# CHECK-NEXT: 1 20 17.00 * pcmpistri $1, (%rax), %xmm2
59-
# CHECK-NEXT: 1 13 13.00 pcmpistrm $1, %xmm0, %xmm2
60-
# CHECK-NEXT: 1 16 13.00 * pcmpistrm $1, (%rax), %xmm2
53+
# CHECK-NEXT: 9 21 21.00 pcmpestri $1, %xmm0, %xmm2
54+
# CHECK-NEXT: 10 24 21.00 * pcmpestri $1, (%rax), %xmm2
55+
# CHECK-NEXT: 8 17 17.00 pcmpestrm $1, %xmm0, %xmm2
56+
# CHECK-NEXT: 9 20 17.00 * pcmpestrm $1, (%rax), %xmm2
57+
# CHECK-NEXT: 6 17 17.00 pcmpistri $1, %xmm0, %xmm2
58+
# CHECK-NEXT: 7 20 17.00 * pcmpistri $1, (%rax), %xmm2
59+
# CHECK-NEXT: 5 13 13.00 pcmpistrm $1, %xmm0, %xmm2
60+
# CHECK-NEXT: 6 16 13.00 * pcmpistrm $1, (%rax), %xmm2
6161
# CHECK-NEXT: 1 1 0.50 pcmpgtq %xmm0, %xmm2
6262
# CHECK-NEXT: 1 4 1.00 * pcmpgtq (%rax), %xmm2
6363

0 commit comments

Comments
 (0)