[clang][sema] ActOnExplicitInstantiation - remove Prev nullptr check

RKSimon · RKSimon · commit 5fb180704c17 · 2022-02-11T15:09:44.000Z
All paths have already dereferenced the Prev pointer
diff --git a/clang/lib/Sema/SemaTemplate.cpp b/clang/lib/Sema/SemaTemplate.cpp
@@ -10116,7 +10116,7 @@ DeclResult Sema::ActOnExplicitInstantiation(Scope *S,
     }
 
     // Check the new variable specialization against the parsed input.
-    if (PrevTemplate && Prev && !Context.hasSameType(Prev->getType(), R)) {
+    if (PrevTemplate && !Context.hasSameType(Prev->getType(), R)) {
       Diag(T->getTypeLoc().getBeginLoc(),
            diag::err_invalid_var_template_spec_type)
           << 0 << PrevTemplate << R << Prev->getType();

Original file line number	Diff line number	Diff line change
`@@ -10116,7 +10116,7 @@ DeclResult Sema::ActOnExplicitInstantiation(Scope *S,`
`10116`	`10116`	`}`
`10117`	`10117`
`10118`	`10118`	`// Check the new variable specialization against the parsed input.`
`10119`		`- if (PrevTemplate && Prev && !Context.hasSameType(Prev->getType(), R)) {`
	`10119`	`+ if (PrevTemplate && !Context.hasSameType(Prev->getType(), R)) {`
`10120`	`10120`	`Diag(T->getTypeLoc().getBeginLoc(),`
`10121`	`10121`	`diag::err_invalid_var_template_spec_type)`
`10122`	`10122`	`<< 0 << PrevTemplate << R << Prev->getType();`