Skip to content

Commit 613f12d

Browse files
committed
[AArch64][GlobalISel] Set the current debug loc when missing in some cases.
1 parent 21caba5 commit 613f12d

File tree

5 files changed

+8
-6
lines changed

5 files changed

+8
-6
lines changed

llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -570,7 +570,7 @@ llvm::createMemLibcall(MachineIRBuilder &MIRBuilder, MachineRegisterInfo &MRI,
570570
}
571571
const char *Name = TLI.getLibcallName(RTLibcall);
572572

573-
MIRBuilder.setInstr(MI);
573+
MIRBuilder.setInstrAndDebugLoc(MI);
574574

575575
CallLowering::CallLoweringInfo Info;
576576
Info.CallConv = TLI.getLibcallCallingConv(RTLibcall);
@@ -3610,7 +3610,7 @@ LegalizerHelper::moreElementsVectorPhi(MachineInstr &MI, unsigned TypeIdx,
36103610
LegalizerHelper::LegalizeResult
36113611
LegalizerHelper::moreElementsVector(MachineInstr &MI, unsigned TypeIdx,
36123612
LLT MoreTy) {
3613-
MIRBuilder.setInstr(MI);
3613+
MIRBuilder.setInstrAndDebugLoc(MI);
36143614
unsigned Opc = MI.getOpcode();
36153615
switch (Opc) {
36163616
case TargetOpcode::G_IMPLICIT_DEF:

llvm/lib/Target/AArch64/AArch64LegalizerInfo.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -675,7 +675,7 @@ bool AArch64LegalizerInfo::legalizeShlAshrLshr(
675675
if (Amount > 31)
676676
return true; // This will have to remain a register variant.
677677
assert(MRI.getType(AmtReg).getSizeInBits() == 32);
678-
MIRBuilder.setInstr(MI);
678+
MIRBuilder.setInstrAndDebugLoc(MI);
679679
auto ExtCst = MIRBuilder.buildZExt(LLT::scalar(64), AmtReg);
680680
MI.getOperand(2).setReg(ExtCst.getReg(0));
681681
return true;
@@ -704,7 +704,7 @@ bool AArch64LegalizerInfo::legalizeLoadStore(
704704
return false;
705705
}
706706

707-
MIRBuilder.setInstr(MI);
707+
MIRBuilder.setInstrAndDebugLoc(MI);
708708
unsigned PtrSize = ValTy.getElementType().getSizeInBits();
709709
const LLT NewTy = LLT::vector(ValTy.getNumElements(), PtrSize);
710710
auto &MMO = **MI.memoperands_begin();
@@ -722,7 +722,7 @@ bool AArch64LegalizerInfo::legalizeLoadStore(
722722
bool AArch64LegalizerInfo::legalizeVaArg(MachineInstr &MI,
723723
MachineRegisterInfo &MRI,
724724
MachineIRBuilder &MIRBuilder) const {
725-
MIRBuilder.setInstr(MI);
725+
MIRBuilder.setInstrAndDebugLoc(MI);
726726
MachineFunction &MF = MIRBuilder.getMF();
727727
Align Alignment(MI.getOperand(2).getImm());
728728
Register Dst = MI.getOperand(0).getReg();

llvm/test/CodeGen/AArch64/GlobalISel/legalize-load-store-vector-of-ptr.mir

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
22
# RUN: llc -O0 -march=aarch64 -run-pass=legalizer %s -o - | FileCheck %s
3+
# RUN: llc -O0 -debugify-and-strip-all-safe -march=aarch64 -run-pass=legalizer -verify-machineinstrs %s -o - | FileCheck %s
34
--- |
45
target datalayout = "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128"
56
target triple = "aarch64"

llvm/test/CodeGen/AArch64/GlobalISel/legalize-shift.mir

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
22
# RUN: llc -O0 -march=aarch64 -run-pass=legalizer %s -o - | FileCheck %s
3+
# RUN: llc -O0 -debugify-and-strip-all-safe -march=aarch64 -run-pass=legalizer -verify-machineinstrs %s -o - | FileCheck %s
34
---
45
name: test_shift
56
body: |

llvm/test/CodeGen/AArch64/GlobalISel/legalize-vaarg.mir

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
2-
# RUN: llc -O0 -run-pass=legalizer %s -o - | FileCheck %s
2+
# RUN: llc -O0 -run-pass=legalizer --debugify-and-strip-all-safe --debugify-level=locations %s -o - | FileCheck %s
33

44
--- |
55
target datalayout = "e-m:o-i64:64-i128:128-n32:64-S128"

0 commit comments

Comments
 (0)