[lldb] Fix SBPlatform after f4be9ff

bulbazord · bulbazord · commit 623ad8a8ddc9 · 2023-06-14T15:46:00.000-07:00
If you pass `nullptr` (or `None` from python) to SBPlatform::SetSDKRoot, LLDB crashes. Let's be more resilient to `nullptr` here. Differential Revision: https://reviews.llvm.org/D152962
diff --git a/lldb/source/API/SBPlatform.cpp b/lldb/source/API/SBPlatform.cpp
@@ -488,7 +488,7 @@ uint32_t SBPlatform::GetOSUpdateVersion() {
 void SBPlatform::SetSDKRoot(const char *sysroot) {
   LLDB_INSTRUMENT_VA(this, sysroot);
   if (PlatformSP platform_sp = GetSP())
-    platform_sp->SetSDKRootDirectory(sysroot);
+    platform_sp->SetSDKRootDirectory(llvm::StringRef(sysroot).str());
 }
 
 SBError SBPlatform::Get(SBFileSpec &src, SBFileSpec &dst) {

Original file line number	Diff line number	Diff line change
`@@ -488,7 +488,7 @@ uint32_t SBPlatform::GetOSUpdateVersion() {`
`488`	`488`	`void SBPlatform::SetSDKRoot(const char *sysroot) {`
`489`	`489`	`LLDB_INSTRUMENT_VA(this, sysroot);`
`490`	`490`	`if (PlatformSP platform_sp = GetSP())`
`491`		`- platform_sp->SetSDKRootDirectory(sysroot);`
	`491`	`+ platform_sp->SetSDKRootDirectory(llvm::StringRef(sysroot).str());`
`492`	`492`	`}`
`493`	`493`
`494`	`494`	`SBError SBPlatform::Get(SBFileSpec &src, SBFileSpec &dst) {`