Skip to content

Commit 62851ea

Browse files
committed
[MLIR] Rename free function verify on OffsetSizeAndStrideOpInterface
Using a free function verify(<Op>) is error prone. Rename it. Differential Revision: https://reviews.llvm.org/D101886
1 parent 491a3d1 commit 62851ea

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

mlir/include/mlir/Interfaces/ViewLikeInterface.h

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,10 @@ struct Range {
2929
};
3030

3131
class OffsetSizeAndStrideOpInterface;
32-
LogicalResult verify(OffsetSizeAndStrideOpInterface op);
32+
33+
namespace detail {
34+
LogicalResult verifyOffsetSizeAndStrideOp(OffsetSizeAndStrideOpInterface op);
35+
} // namespace detail
3336
} // namespace mlir
3437

3538
/// Include the generated interface declarations.

mlir/include/mlir/Interfaces/ViewLikeInterface.td

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -445,7 +445,8 @@ def OffsetSizeAndStrideOpInterface : OpInterface<"OffsetSizeAndStrideOpInterface
445445
}];
446446

447447
let verify = [{
448-
return ::mlir::verify(::mlir::cast<::mlir::OffsetSizeAndStrideOpInterface>($_op));
448+
return ::mlir::detail::verifyOffsetSizeAndStrideOp(
449+
::mlir::cast<::mlir::OffsetSizeAndStrideOpInterface>($_op));
449450
}];
450451
}
451452

mlir/lib/Interfaces/ViewLikeInterface.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@ LogicalResult mlir::verifyListOfOperandsOrIntegers(
3434
return success();
3535
}
3636

37-
LogicalResult mlir::verify(OffsetSizeAndStrideOpInterface op) {
37+
LogicalResult
38+
mlir::detail::verifyOffsetSizeAndStrideOp(OffsetSizeAndStrideOpInterface op) {
3839
std::array<unsigned, 3> maxRanks = op.getArrayAttrMaxRanks();
3940
// Offsets can come in 2 flavors:
4041
// 1. Either single entry (when maxRanks == 1).

0 commit comments

Comments
 (0)