[NFC] Drop typeCheckExternalDefinitions

CodaFi · CodaFi · commit 646ec555e43d · 2019-11-11T15:20:06.000-08:00
performTypeChecking will handle the nitty-gritty of closure captures,
and external declarations are now eagerly typechecked.  There's no
reason to call this after the playground transform.
diff --git a/lldb/source/Plugins/ExpressionParser/Swift/SwiftExpressionParser.cpp b/lldb/source/Plugins/ExpressionParser/Swift/SwiftExpressionParser.cpp
@@ -1498,7 +1498,6 @@ unsigned SwiftExpressionParser::Parse(DiagnosticManager &diagnostic_manager,
     }
   } else {
     swift::performPlaygroundTransform(parsed_expr->source_file, true);
-    swift::typeCheckExternalDefinitions(parsed_expr->source_file);
   }
 
   // FIXME: We now should have to do the name binding and type

Original file line number	Diff line number	Diff line change
`@@ -1498,7 +1498,6 @@ unsigned SwiftExpressionParser::Parse(DiagnosticManager &diagnostic_manager,`
`1498`	`1498`	`}`
`1499`	`1499`	`} else {`
`1500`	`1500`	`swift::performPlaygroundTransform(parsed_expr->source_file, true);`
`1501`		`- swift::typeCheckExternalDefinitions(parsed_expr->source_file);`
`1502`	`1501`	`}`
`1503`	`1502`
`1504`	`1503`	`// FIXME: We now should have to do the name binding and type`