[lldb] Minor fixups for Part 2 of 2 CommandObject::DoExecute(...)

Author: PortalPete

lldb/source/Commands/CommandObjectHealthcheck.cpp

@@ -30,7 +30,7 @@ CommandObjectHealthcheck::CommandObjectHealthcheck(
           "failures in the debugger. The command is meant to be run after a "
           "expression evaluator failure has occurred.") {}
 
-bool CommandObjectHealthcheck::DoExecute(Args &args,
+void CommandObjectHealthcheck::DoExecute(Args &args,
                                          CommandReturnObject &result) {
   std::error_code err;
   llvm::SmallString<128> temp_path;
@@ -47,7 +47,7 @@ bool CommandObjectHealthcheck::DoExecute(Args &args,
   if (temp_fd == -1) {
     result.AppendErrorWithFormat("could not write to temp file %s",
                                  err.message().c_str());
-    return false;
+    return;
   }
 
   llvm::raw_fd_ostream temp_stream(temp_fd, true, true);
@@ -65,9 +65,8 @@ bool CommandObjectHealthcheck::DoExecute(Args &args,
       Host::IsInteractiveGraphicSession()) {
     if (llvm::Error err =
             Host::OpenFileInExternalEditor("", FileSpec(temp_path), 0))
-      return false;
+      return;
   }
 #endif
 
-  return true;
 }

lldb/source/Commands/CommandObjectHealthcheck.h

@@ -20,7 +20,7 @@ class CommandObjectHealthcheck : public CommandObjectParsed {
   ~CommandObjectHealthcheck() override = default;
 
 protected:
-  bool DoExecute(Args &args, CommandReturnObject &result) override;
+  void DoExecute(Args &args, CommandReturnObject &result) override;
 };
 
 } // namespace lldb_private

lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntime.cpp

@@ -2170,7 +2170,7 @@ class CommandObjectSwift_Demangle : public CommandObjectParsed {
   };
 
 protected:
-  bool DoExecute(Args &command, CommandReturnObject &result) override {
+  void DoExecute(Args &command, CommandReturnObject &result) override {
     for (size_t i = 0; i < command.GetArgumentCount(); i++) {
       StringRef name = command.GetArgumentAtIndex(i);
       if (!name.empty()) {
@@ -2195,7 +2195,6 @@ class CommandObjectSwift_Demangle : public CommandObjectParsed {
       }
     }
     result.SetStatus(lldb::eReturnStatusSuccessFinishResult);
-    return true;
   }
 
   CommandOptions m_options;
@@ -2259,7 +2258,7 @@ class CommandObjectSwift_RefCount : public CommandObjectRaw {
   }
 
 protected:
-  bool DoExecute(llvm::StringRef command,
+  void DoExecute(llvm::StringRef command,
                  CommandReturnObject &result) override {
     StackFrameSP frame_sp(m_exe_ctx.GetFrameSP());
     EvaluateExpressionOptions options;
@@ -2278,7 +2277,7 @@ class CommandObjectSwift_RefCount : public CommandObjectRaw {
       result.SetStatus(lldb::eReturnStatusFailed);
       if (result_valobj_sp && result_valobj_sp->GetError().Fail())
         result.AppendError(result_valobj_sp->GetError().AsCString());
-      return false;
+      return;
     }
 
     // At this point, we're sure we're grabbing in our hands a valid
@@ -2291,7 +2290,7 @@ class CommandObjectSwift_RefCount : public CommandObjectRaw {
     if (!(result_type.GetTypeInfo() & lldb::eTypeInstanceIsPointer)) {
       result.AppendError("refcount only available for class types");
       result.SetStatus(lldb::eReturnStatusFailed);
-      return false;
+      return;
     }
 
     // Ask swift debugger support in the compiler about the objects
@@ -2311,7 +2310,6 @@ class CommandObjectSwift_RefCount : public CommandObjectRaw {
         unowned ? std::to_string(*unowned).c_str() : unavailable.c_str(),
         weak ? std::to_string(*weak).c_str() : unavailable.c_str());
     result.SetStatus(lldb::eReturnStatusSuccessFinishResult);
-    return true;
   }
 };