Merge pull request #1456 from augusto2112/remove-dynamic-class-type-check-materialization-next

Remove bypass of GetAddressOf when dealing with dynamic class types in variable materialization (swift/master-next)

Author: adrian-prantl

lldb/source/Expression/Materializer.cpp

@@ -494,19 +494,12 @@ class EntityVariable : public Materializer::Entity {
       }
     } else {
       AddressType address_type = eAddressTypeInvalid;
-      const bool is_dynamic_class_type =
-          m_is_generic &&
-          (valobj_type.GetTypeClass() == lldb::eTypeClassClass);
       const bool scalar_is_load_address = m_is_generic; // this is the only
                                                           // time we're dealing
                                                           // with dynamic values
 
-      // if the dynamic type is a class, bypass the GetAddressOf() optimization
-      // as it doesn't do the right thing
       lldb::addr_t addr_of_valobj =
-          is_dynamic_class_type
-              ? LLDB_INVALID_ADDRESS
-              : valobj_sp->GetAddressOf(scalar_is_load_address, &address_type);
+          valobj_sp->GetAddressOf(scalar_is_load_address, &address_type);
 
       // BEGIN Swift.
       if (lldb::ProcessSP process_sp =