Skip to content

Commit 6b4ddf4

Browse files
committed
dependency cycle fix in DynamicLoaderDarwinKernel
DynamicLoaderDarwinKernel calls in to PlatformDarwinKernel, and with my changes in https://reviews.llvm.org/D133534, PlatformDarwinKernel calls in to DynamicLoaderDarwinKernel. This results in a cmake dependency if accurately included in the link libraries list. lldbPluginDynamicLoaderDarwinKernel is specfically for kernel debugging and is uncommonly linked in to anything except a full lldb. lldbPluginPlatformMacOSX is any Darwin platform, including PlatformDarwinKernel, and is referenced a number of time in shell tests, for instance. I believe anything linking the darwin kernel DynamicLoader plugin will already have lldbPluginPlatformMacOSX in its dependency list, so not explicitly expressing this dependency is safe. (cherry picked from commit 30578c0)
1 parent 8a568a7 commit 6b4ddf4

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

lldb/source/Plugins/DynamicLoader/Darwin-Kernel/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ add_lldb_library(lldbPluginDynamicLoaderDarwinKernel PLUGIN
1717
lldbSymbol
1818
lldbTarget
1919
lldbUtility
20-
lldbPluginPlatformMacOSX
2120
)
2221

2322
add_dependencies(lldbPluginDynamicLoaderDarwinKernel

0 commit comments

Comments
 (0)