[flang][driver] Fix a small bug (auto vs auto&)

banach-space · banach-space · commit 6bbbe4a5746e · 2020-12-14T16:10:07.000Z
This bug hasn't affected us yet as our usage is too basic, i.e. we don't
rely on the defaults provided by `SetDefaultFortranOpts` just yet. This
will change shortly.
diff --git a/flang/lib/Frontend/CompilerInvocation.cpp b/flang/lib/Frontend/CompilerInvocation.cpp
@@ -185,7 +185,7 @@ bool CompilerInvocation::CreateFromArgs(CompilerInvocation &res,
 }
 
 void CompilerInvocation::SetDefaultFortranOpts() {
-  auto fortranOptions = fortranOpts();
+  auto &fortranOptions = fortranOpts();
 
   // These defaults are based on the defaults in f18/f18.cpp.
   std::vector<std::string> searchDirectories{"."s};

Original file line number	Diff line number	Diff line change
`@@ -185,7 +185,7 @@ bool CompilerInvocation::CreateFromArgs(CompilerInvocation &res,`
`185`	`185`	`}`
`186`	`186`
`187`	`187`	`void CompilerInvocation::SetDefaultFortranOpts() {`
`188`		`- auto fortranOptions = fortranOpts();`
	`188`	`+ auto &fortranOptions = fortranOpts();`
`189`	`189`
`190`	`190`	`// These defaults are based on the defaults in f18/f18.cpp.`
`191`	`191`	`std::vector<std::string> searchDirectories{"."s};`