Skip to content

Commit 6f0f022

Browse files
committed
[OpenMP] Update allocator trait key/value definitions
Use new definitions introduced in 5.1 specification. Differential Revision: https://reviews.llvm.org/D94277
1 parent 6529d7c commit 6f0f022

File tree

5 files changed

+19
-14
lines changed

5 files changed

+19
-14
lines changed

openmp/runtime/src/include/omp.h.var

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@
307307
typedef uintptr_t omp_uintptr_t;
308308

309309
typedef enum {
310-
omp_atk_threadmodel = 1,
310+
omp_atk_sync_hint = 1,
311311
omp_atk_alignment = 2,
312312
omp_atk_access = 3,
313313
omp_atk_pool_size = 4,
@@ -320,10 +320,10 @@
320320
typedef enum {
321321
omp_atv_false = 0,
322322
omp_atv_true = 1,
323-
omp_atv_default = 2,
324323
omp_atv_contended = 3,
325324
omp_atv_uncontended = 4,
326-
omp_atv_sequential = 5,
325+
omp_atv_serialized = 5,
326+
omp_atv_sequential = omp_atv_serialized, // (deprecated)
327327
omp_atv_private = 6,
328328
omp_atv_all = 7,
329329
omp_atv_thread = 8,
@@ -338,6 +338,7 @@
338338
omp_atv_blocked = 17,
339339
omp_atv_interleaved = 18
340340
} omp_alloctrait_value_t;
341+
#define omp_atv_default ((omp_uintptr_t)-1)
341342

342343
typedef struct {
343344
omp_alloctrait_key_t key;

openmp/runtime/src/include/omp_lib.f90.var

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@
9898
integer (kind=omp_control_tool_result_kind), parameter :: omp_control_tool_success = 0
9999
integer (kind=omp_control_tool_result_kind), parameter :: omp_control_tool_ignored = 1
100100

101-
integer (kind=omp_alloctrait_key_kind), parameter :: omp_atk_threadmodel = 1
101+
integer (kind=omp_alloctrait_key_kind), parameter :: omp_atk_sync_hint = 1
102102
integer (kind=omp_alloctrait_key_kind), parameter :: omp_atk_alignment = 2
103103
integer (kind=omp_alloctrait_key_kind), parameter :: omp_atk_access = 3
104104
integer (kind=omp_alloctrait_key_kind), parameter :: omp_atk_pool_size = 4
@@ -107,12 +107,13 @@
107107
integer (kind=omp_alloctrait_key_kind), parameter :: omp_atk_pinned = 7
108108
integer (kind=omp_alloctrait_key_kind), parameter :: omp_atk_partition = 8
109109

110+
integer (kind=omp_alloctrait_val_kind), parameter :: omp_atv_default = -1
110111
integer (kind=omp_alloctrait_val_kind), parameter :: omp_atv_false = 0
111112
integer (kind=omp_alloctrait_val_kind), parameter :: omp_atv_true = 1
112-
integer (kind=omp_alloctrait_val_kind), parameter :: omp_atv_default = 2
113113
integer (kind=omp_alloctrait_val_kind), parameter :: omp_atv_contended = 3
114114
integer (kind=omp_alloctrait_val_kind), parameter :: omp_atv_uncontended = 4
115-
integer (kind=omp_alloctrait_val_kind), parameter :: omp_atv_sequential = 5
115+
integer (kind=omp_alloctrait_val_kind), parameter :: omp_atv_serialized = 5
116+
integer (kind=omp_alloctrait_val_kind), parameter :: omp_atv_sequential = omp_atv_serialized
116117
integer (kind=omp_alloctrait_val_kind), parameter :: omp_atv_private = 6
117118
integer (kind=omp_alloctrait_val_kind), parameter :: omp_atv_all = 7
118119
integer (kind=omp_alloctrait_val_kind), parameter :: omp_atv_thread = 8

openmp/runtime/src/include/omp_lib.h.var

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -131,8 +131,8 @@
131131
integer(omp_control_tool_result_kind)omp_control_tool_ignored
132132
parameter(omp_control_tool_ignored=1)
133133

134-
integer(kind=omp_alloctrait_key_kind)omp_atk_threadmodel
135-
parameter(omp_atk_threadmodel=1)
134+
integer(kind=omp_alloctrait_key_kind)omp_atk_sync_hint
135+
parameter(omp_atk_sync_hint=1)
136136
integer(kind=omp_alloctrait_key_kind)omp_atk_alignment
137137
parameter(omp_atk_alignment=2)
138138
integer(kind=omp_alloctrait_key_kind)omp_atk_access
@@ -148,18 +148,20 @@
148148
integer(kind=omp_alloctrait_key_kind)omp_atk_partition
149149
parameter(omp_atk_partition=8)
150150

151+
integer(kind=omp_alloctrait_val_kind)omp_atv_default
152+
parameter(omp_atv_default=-1)
151153
! Reserved for future use
152154
integer(kind=omp_alloctrait_val_kind)omp_atv_false
153155
parameter(omp_atv_false=0)
154156
! Reserved for future use
155157
integer(kind=omp_alloctrait_val_kind)omp_atv_true
156158
parameter(omp_atv_true=1)
157-
integer(kind=omp_alloctrait_val_kind)omp_atv_default
158-
parameter(omp_atv_default=2)
159159
integer(kind=omp_alloctrait_val_kind)omp_atv_contended
160160
parameter(omp_atv_contended=3)
161161
integer(kind=omp_alloctrait_val_kind)omp_atv_uncontended
162162
parameter(omp_atv_uncontended=4)
163+
integer(kind=omp_alloctrait_val_kind)omp_atv_serialized
164+
parameter(omp_atv_serialized=5)
163165
integer(kind=omp_alloctrait_val_kind)omp_atv_sequential
164166
parameter(omp_atv_sequential=5)
165167
integer(kind=omp_alloctrait_val_kind)omp_atv_private

openmp/runtime/src/kmp.h

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -890,7 +890,7 @@ extern int __kmp_hws_abs_flag; // absolute or per-item number requested
890890
typedef uintptr_t omp_uintptr_t;
891891

892892
typedef enum {
893-
omp_atk_threadmodel = 1,
893+
omp_atk_sync_hint = 1,
894894
omp_atk_alignment = 2,
895895
omp_atk_access = 3,
896896
omp_atk_pool_size = 4,
@@ -903,10 +903,10 @@ typedef enum {
903903
typedef enum {
904904
omp_atv_false = 0,
905905
omp_atv_true = 1,
906-
omp_atv_default = 2,
907906
omp_atv_contended = 3,
908907
omp_atv_uncontended = 4,
909-
omp_atv_sequential = 5,
908+
omp_atv_serialized = 5,
909+
omp_atv_sequential = omp_atv_serialized, // (deprecated)
910910
omp_atv_private = 6,
911911
omp_atv_all = 7,
912912
omp_atv_thread = 8,
@@ -921,6 +921,7 @@ typedef enum {
921921
omp_atv_blocked = 17,
922922
omp_atv_interleaved = 18
923923
} omp_alloctrait_value_t;
924+
#define omp_atv_default ((omp_uintptr_t)-1)
924925

925926
typedef void *omp_memspace_handle_t;
926927
extern omp_memspace_handle_t const omp_default_mem_space;

openmp/runtime/src/kmp_alloc.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1348,7 +1348,7 @@ omp_allocator_handle_t __kmpc_init_allocator(int gtid, omp_memspace_handle_t ms,
13481348
al->memspace = ms; // not used currently
13491349
for (i = 0; i < ntraits; ++i) {
13501350
switch (traits[i].key) {
1351-
case omp_atk_threadmodel:
1351+
case omp_atk_sync_hint:
13521352
case omp_atk_access:
13531353
case omp_atk_pinned:
13541354
break;

0 commit comments

Comments
 (0)