Skip to content

Commit 7221516

Browse files
authored
[InstCombine] Fix typo in adjustKnownBitsForSelectArm (llvm#98155)
Fixes llvm#98139.
1 parent 6aefa91 commit 7221516

File tree

2 files changed

+27
-1
lines changed

2 files changed

+27
-1
lines changed

llvm/lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,7 @@ Value *InstCombinerImpl::SimplifyDemandedUseBits(Instruction *I,
411411
// Only known if known in both the LHS and RHS.
412412
adjustKnownBitsForSelectArm(LHSKnown, I->getOperand(0), I->getOperand(1),
413413
/*Invert=*/false, Depth, Q);
414-
adjustKnownBitsForSelectArm(LHSKnown, I->getOperand(0), I->getOperand(2),
414+
adjustKnownBitsForSelectArm(RHSKnown, I->getOperand(0), I->getOperand(2),
415415
/*Invert=*/true, Depth, Q);
416416
Known = LHSKnown.intersectWith(RHSKnown);
417417
break;
Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 5
2+
; RUN: opt -S -passes=instcombine < %s | FileCheck %s
3+
4+
define i8 @pr98139(i16 %a, i16 %b, i1 %cond) {
5+
; CHECK-LABEL: define i8 @pr98139(
6+
; CHECK-SAME: i16 [[A:%.*]], i16 [[B:%.*]], i1 [[COND:%.*]]) {
7+
; CHECK-NEXT: [[SEL:%.*]] = select i1 [[COND]], i16 1, i16 254
8+
; CHECK-NEXT: [[COND1:%.*]] = icmp ne i16 [[B]], 0
9+
; CHECK-NEXT: [[MASK:%.*]] = and i16 [[A]], 255
10+
; CHECK-NEXT: [[COND2:%.*]] = icmp ne i16 [[MASK]], 255
11+
; CHECK-NEXT: [[COND3:%.*]] = or i1 [[COND1]], [[COND2]]
12+
; CHECK-NEXT: [[SEL2:%.*]] = select i1 [[COND3]], i16 [[SEL]], i16 255
13+
; CHECK-NEXT: [[SUB:%.*]] = sub i16 [[SEL2]], [[A]]
14+
; CHECK-NEXT: [[TRUNC:%.*]] = trunc i16 [[SUB]] to i8
15+
; CHECK-NEXT: ret i8 [[TRUNC]]
16+
;
17+
%sel = select i1 %cond, i16 1, i16 254
18+
%cond1 = icmp ne i16 %b, 0
19+
%mask = and i16 %a, 255
20+
%cond2 = icmp ne i16 %mask, 255
21+
%cond3 = or i1 %cond1, %cond2
22+
%sel2 = select i1 %cond3, i16 %sel, i16 255
23+
%sub = sub i16 %sel2, %a
24+
%trunc = trunc i16 %sub to i8
25+
ret i8 %trunc
26+
}

0 commit comments

Comments
 (0)