Skip to content

Commit 79762a1

Browse files
asbasb
committed
[test][LoopIidiom][NFC] Add --check-globals to several tests
This reduces the diff for upcoming changes. In some cases there were already CHECK lines for the globals, but re-running update_test_check.py deletes them without --check-globals being added. For memset-pattern-tbaa.ll, the globals weren't checked but should have been.
1 parent 20637e7 commit 79762a1

File tree

4 files changed

+48
-9
lines changed

4 files changed

+48
-9
lines changed

‎llvm/test/Transforms/LoopIdiom/memset-pattern-tbaa.ll

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,16 @@
1-
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
1+
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --check-globals
22
; RUN: opt -passes="loop-idiom" < %s -S | FileCheck %s
33

44
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64"
55

66
target triple = "x86_64-apple-darwin10.0.0"
77

88

9+
;.
10+
; CHECK: @.memset_pattern = private unnamed_addr constant [2 x double] [double 3.141590e+00, double 3.141590e+00], align 16
11+
; CHECK: @.memset_pattern.1 = private unnamed_addr constant [2 x double] [double 3.141590e+00, double 3.141590e+00], align 16
12+
; CHECK: @.memset_pattern.2 = private unnamed_addr constant [2 x double] [double 3.141590e+00, double 3.141590e+00], align 16
13+
;.
914
define dso_local void @double_memset(ptr nocapture %p) {
1015
; CHECK-LABEL: @double_memset(
1116
; CHECK-NEXT: entry:
@@ -110,3 +115,15 @@ for.body:
110115
!20 = !{!"any pointer", !7, i64 0}
111116
!21 = !{!22, !20, i64 0}
112117
!22 = !{!"B", !20, i64 0}
118+
;.
119+
; CHECK: attributes #[[ATTR0:[0-9]+]] = { nofree nounwind willreturn memory(argmem: readwrite) }
120+
;.
121+
; CHECK: [[TBAA0]] = !{[[META1:![0-9]+]], [[META1]], i64 0}
122+
; CHECK: [[META1]] = !{!"double", [[META2:![0-9]+]], i64 0}
123+
; CHECK: [[META2]] = !{!"omnipotent char", [[META3:![0-9]+]], i64 0}
124+
; CHECK: [[META3]] = !{!"Simple C++ TBAA"}
125+
; CHECK: [[TBAA4]] = !{[[META5:![0-9]+]], [[META7:![0-9]+]], i64 0, i64 128}
126+
; CHECK: [[META5]] = !{[[META6:![0-9]+]], i64 32, !"_ZTS1A", [[META7]], i64 0, i64 8, [[META7]], i64 8, i64 8, [[META7]], i64 16, i64 8, [[META7]], i64 24, i64 8}
127+
; CHECK: [[META6]] = !{[[META3]], i64 0, !"omnipotent char"}
128+
; CHECK: [[META7]] = !{[[META6]], i64 8, !"double"}
129+
;.

‎llvm/test/Transforms/LoopIdiom/struct_pattern.ll

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
1-
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
1+
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --check-globals
22
; RUN: opt -passes=loop-idiom < %s -S | FileCheck %s
33
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64"
44

5-
; CHECK: @.memset_pattern = private unnamed_addr constant [4 x i32] [i32 2, i32 2, i32 2, i32 2], align 16
6-
; CHECK: @.memset_pattern.1 = private unnamed_addr constant [4 x i32] [i32 2, i32 2, i32 2, i32 2], align 16
7-
; CHECK: @.memset_pattern.2 = private unnamed_addr constant [4 x i32] [i32 2, i32 2, i32 2, i32 2], align 16
85

96
target triple = "x86_64-apple-darwin10.0.0"
107

@@ -17,6 +14,13 @@ target triple = "x86_64-apple-darwin10.0.0"
1714
; f[i].b = 2;
1815
; }
1916
;}
17+
18+
19+
;.
20+
; CHECK: @.memset_pattern = private unnamed_addr constant [4 x i32] [i32 2, i32 2, i32 2, i32 2], align 16
21+
; CHECK: @.memset_pattern.1 = private unnamed_addr constant [4 x i32] [i32 2, i32 2, i32 2, i32 2], align 16
22+
; CHECK: @.memset_pattern.2 = private unnamed_addr constant [4 x i32] [i32 2, i32 2, i32 2, i32 2], align 16
23+
;.
2024
define void @bar1(ptr %f, i32 %n) nounwind ssp {
2125
; CHECK-LABEL: @bar1(
2226
; CHECK-NEXT: entry:
@@ -286,3 +290,7 @@ for.end.loopexit: ; preds = %for.body
286290
for.end: ; preds = %for.end.loopexit, %entry
287291
ret void
288292
}
293+
;.
294+
; CHECK: attributes #[[ATTR0:[0-9]+]] = { nounwind ssp }
295+
; CHECK: attributes #[[ATTR1:[0-9]+]] = { nofree nounwind willreturn memory(argmem: readwrite) }
296+
;.

‎llvm/test/Transforms/LoopIdiom/unroll-custom-dl.ll

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
1-
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
1+
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --check-globals
22
; RUN: opt -passes=loop-idiom < %s -S | FileCheck %s
33
target datalayout = "e-p:64:64:64:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64"
44

5-
; CHECK: @.memset_pattern = private unnamed_addr constant [4 x i32] [i32 2, i32 2, i32 2, i32 2], align 16
65

76
target triple = "x86_64-apple-darwin10.0.0"
87

@@ -12,6 +11,9 @@ target triple = "x86_64-apple-darwin10.0.0"
1211
; f[i+1] = 0;
1312
; }
1413
;}
14+
;.
15+
; CHECK: @.memset_pattern = private unnamed_addr constant [4 x i32] [i32 2, i32 2, i32 2, i32 2], align 16
16+
;.
1517
define void @test(ptr %f, i32 %n) nounwind ssp {
1618
; CHECK-LABEL: @test(
1719
; CHECK-NEXT: entry:
@@ -121,3 +123,8 @@ for.end.loopexit: ; preds = %for.body
121123
for.end: ; preds = %for.end.loopexit, %entry
122124
ret void
123125
}
126+
;.
127+
; CHECK: attributes #[[ATTR0:[0-9]+]] = { nounwind ssp }
128+
; CHECK: attributes #[[ATTR1:[0-9]+]] = { nocallback nofree nounwind willreturn memory(argmem: write) }
129+
; CHECK: attributes #[[ATTR2:[0-9]+]] = { nofree nounwind willreturn memory(argmem: readwrite) }
130+
;.

‎llvm/test/Transforms/LoopIdiom/unroll.ll

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
1-
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
1+
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --check-globals
22
; RUN: opt -passes=loop-idiom < %s -S | FileCheck %s
33
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64"
44

5-
; CHECK: @.memset_pattern = private unnamed_addr constant [4 x i32] [i32 2, i32 2, i32 2, i32 2], align 16
65

76
target triple = "x86_64-apple-darwin10.0.0"
87

@@ -12,6 +11,9 @@ target triple = "x86_64-apple-darwin10.0.0"
1211
; f[i+1] = 0;
1312
; }
1413
;}
14+
;.
15+
; CHECK: @.memset_pattern = private unnamed_addr constant [4 x i32] [i32 2, i32 2, i32 2, i32 2], align 16
16+
;.
1517
define void @test(ptr %f, i32 %n) nounwind ssp {
1618
; CHECK-LABEL: @test(
1719
; CHECK-NEXT: entry:
@@ -125,3 +127,8 @@ for.end.loopexit: ; preds = %for.body
125127
for.end: ; preds = %for.end.loopexit, %entry
126128
ret void
127129
}
130+
;.
131+
; CHECK: attributes #[[ATTR0:[0-9]+]] = { nounwind ssp }
132+
; CHECK: attributes #[[ATTR1:[0-9]+]] = { nocallback nofree nounwind willreturn memory(argmem: write) }
133+
; CHECK: attributes #[[ATTR2:[0-9]+]] = { nofree nounwind willreturn memory(argmem: readwrite) }
134+
;.

0 commit comments

Comments
 (0)