Skip to content

Commit 79e9860

Browse files
committed
Revert "Work around outdated system header files on Amazon Linux"
This reverts commit 075b0ac.
1 parent 6743226 commit 79e9860

File tree

3 files changed

+0
-41
lines changed

3 files changed

+0
-41
lines changed

lldb/cmake/modules/LLDBConfig.cmake

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -345,19 +345,4 @@ if ((CMAKE_SYSTEM_NAME MATCHES "Android") AND LLVM_BUILD_STATIC AND
345345
add_definitions(-DANDROID_USE_ACCEPT_WORKAROUND)
346346
endif()
347347

348-
if (CMAKE_SYSTEM_NAME MATCHES "Linux")
349-
check_cxx_source_compiles(
350-
"#include <asm/ptrace.h>
351-
struct user_sve_header hdr;
352-
int main(void){return 0;}
353-
"
354-
user_sve_header_available)
355-
if(user_sve_header_available)
356-
set(LLDB_HAVE_USER_SVE_HEADER ON)
357-
message(STATUS "AArch64 SVE support enabled.")
358-
else()
359-
message(STATUS "AArch64 SVE support disabled.")
360-
endif()
361-
endif()
362-
363348
include(LLDBGenerateConfig)

lldb/include/lldb/Host/Config.h.cmake

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,6 @@
5252

5353
#cmakedefine01 LLDB_EMBED_PYTHON_HOME
5454

55-
#cmakedefine01 LLDB_HAVE_USER_SVE_HEADER
56-
5755
#cmakedefine LLDB_PYTHON_HOME R"(${LLDB_PYTHON_HOME})"
5856

5957
#define LLDB_LIBDIR_SUFFIX "${LLVM_LIBDIR_SUFFIX}"

lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -62,11 +62,7 @@ NativeRegisterContextLinux::CreateHostNativeRegisterContextLinux(
6262
case llvm::Triple::aarch64: {
6363
// Configure register sets supported by this AArch64 target.
6464
// Read SVE header to check for SVE support.
65-
#if LLDB_HAVE_USER_SVE_HEADER
6665
struct user_sve_header sve_header;
67-
#else
68-
struct sve_header {};
69-
#endif
7066
struct iovec ioVec;
7167
ioVec.iov_base = &sve_header;
7268
ioVec.iov_len = sizeof(sve_header);
@@ -211,21 +207,13 @@ NativeRegisterContextLinux_arm64::ReadRegister(const RegisterInfo *reg_info,
211207
if (reg == GetRegisterInfo().GetRegNumFPSR()) {
212208
sve_reg_num = reg;
213209
if (m_sve_state == SVEState::Full)
214-
#if LLDB_HAVE_USER_SVE_HEADER
215210
offset = sve::PTraceFPSROffset(sve::vq_from_vl(m_sve_header.vl));
216-
#else
217-
offset = 0;
218-
#endif
219211
else if (m_sve_state == SVEState::FPSIMD)
220212
offset = sve::ptrace_fpsimd_offset + (32 * 16);
221213
} else if (reg == GetRegisterInfo().GetRegNumFPCR()) {
222214
sve_reg_num = reg;
223215
if (m_sve_state == SVEState::Full)
224-
#if LLDB_HAVE_USER_SVE_HEADER
225216
offset = sve::PTraceFPCROffset(sve::vq_from_vl(m_sve_header.vl));
226-
#else
227-
offset = 0;
228-
#endif
229217
else if (m_sve_state == SVEState::FPSIMD)
230218
offset = sve::ptrace_fpsimd_offset + (32 * 16) + 4;
231219
} else {
@@ -353,21 +341,13 @@ Status NativeRegisterContextLinux_arm64::WriteRegister(
353341
if (reg == GetRegisterInfo().GetRegNumFPSR()) {
354342
sve_reg_num = reg;
355343
if (m_sve_state == SVEState::Full)
356-
#if LLDB_HAVE_USER_SVE_HEADER
357344
offset = sve::PTraceFPSROffset(sve::vq_from_vl(m_sve_header.vl));
358-
#else
359-
offset = 0;
360-
#endif
361345
else if (m_sve_state == SVEState::FPSIMD)
362346
offset = sve::ptrace_fpsimd_offset + (32 * 16);
363347
} else if (reg == GetRegisterInfo().GetRegNumFPCR()) {
364348
sve_reg_num = reg;
365349
if (m_sve_state == SVEState::Full)
366-
#if LLDB_HAVE_USER_SVE_HEADER
367350
offset = sve::PTraceFPCROffset(sve::vq_from_vl(m_sve_header.vl));
368-
#else
369-
offset = 0;
370-
#endif
371351
else if (m_sve_state == SVEState::FPSIMD)
372352
offset = sve::ptrace_fpsimd_offset + (32 * 16) + 4;
373353
} else {
@@ -844,22 +824,18 @@ void NativeRegisterContextLinux_arm64::ConfigureRegisterContext() {
844824
if (error.Success()) {
845825
// If SVE is enabled thread can switch between SVEState::FPSIMD and
846826
// SVEState::Full on every stop.
847-
#if LLDB_HAVE_USER_SVE_HEADER
848827
if ((m_sve_header.flags & sve::ptrace_regs_mask) ==
849828
sve::ptrace_regs_fpsimd)
850829
m_sve_state = SVEState::FPSIMD;
851830
else if ((m_sve_header.flags & sve::ptrace_regs_mask) ==
852831
sve::ptrace_regs_sve)
853832
m_sve_state = SVEState::Full;
854-
#endif
855833

856834
// On every stop we configure SVE vector length by calling
857835
// ConfigureVectorLength regardless of current SVEState of this thread.
858836
uint32_t vq = RegisterInfoPOSIX_arm64::eVectorQuadwordAArch64SVE;
859-
#if LLDB_HAVE_USER_SVE_HEADER
860837
if (sve_vl_valid(m_sve_header.vl))
861838
vq = sve::vq_from_vl(m_sve_header.vl);
862-
#endif
863839

864840
GetRegisterInfo().ConfigureVectorLength(vq);
865841
m_sve_ptrace_payload.resize(sve::PTraceSize(vq, sve::ptrace_regs_sve));

0 commit comments

Comments
 (0)