[CMake][gn] lldMachO=>lldMachOOld, lldMachO2=>lldMachO

MaskRay · MaskRay · commit 7a6482216ff0 · 2021-08-04T18:52:41.000-07:00
Now that D95204 switched default to new Darwin backend, rename some CMake targets to match. Reviewed By: #lld-macho, smeenai, int3 Differential Revision: https://reviews.llvm.org/D107516
diff --git a/lld/MachO/CMakeLists.txt b/lld/MachO/CMakeLists.txt
@@ -4,7 +4,7 @@ add_public_tablegen_target(MachOOptionsTableGen)
 
 include_directories(${LLVM_MAIN_SRC_DIR}/../libunwind/include)
 
-add_lld_library(lldMachO2
+add_lld_library(lldMachO
   Arch/ARM.cpp
   Arch/ARM64.cpp
   Arch/ARM64Common.cpp
@@ -58,5 +58,5 @@ add_lld_library(lldMachO2
   )
 
 if(LLVM_HAVE_LIBXAR)
-  target_link_libraries(lldMachO2 PRIVATE ${XAR_LIB})
+  target_link_libraries(lldMachO PRIVATE ${XAR_LIB})
 endif()
diff --git a/lld/lib/Driver/CMakeLists.txt b/lld/lib/Driver/CMakeLists.txt
@@ -15,7 +15,7 @@ add_lld_library(lldDriver
   LINK_LIBS
     lldCommon
     lldCore
-    lldMachO
+    lldMachOOld
     lldReaderWriter
     lldYAML
   )
diff --git a/lld/lib/ReaderWriter/MachO/CMakeLists.txt b/lld/lib/ReaderWriter/MachO/CMakeLists.txt
@@ -1,4 +1,4 @@
-add_lld_library(lldMachO
+add_lld_library(lldMachOOld
   ArchHandler.cpp
   ArchHandler_arm.cpp
   ArchHandler_arm64.cpp
diff --git a/lld/tools/lld/CMakeLists.txt b/lld/tools/lld/CMakeLists.txt
@@ -15,7 +15,7 @@ target_link_libraries(lld
   lldCOFF
   lldDriver
   lldELF
-  lldMachO2
+  lldMachO
   lldMinGW
   lldWasm
   )
diff --git a/lld/unittests/DriverTests/CMakeLists.txt b/lld/unittests/DriverTests/CMakeLists.txt
@@ -5,5 +5,5 @@ add_lld_unittest(DriverTests
 target_link_libraries(DriverTests
   PRIVATE
   lldDriver
-  lldMachO
+  lldMachOOld
   )
diff --git a/lld/unittests/MachOTests/CMakeLists.txt b/lld/unittests/MachOTests/CMakeLists.txt
@@ -1,14 +1,14 @@
 
-add_lld_unittest(lldMachOTests
+add_lld_unittest(lldMachOOldTests
   MachONormalizedFileBinaryReaderTests.cpp
   MachONormalizedFileBinaryWriterTests.cpp
   MachONormalizedFileToAtomsTests.cpp
   MachONormalizedFileYAMLTests.cpp
   )
 
-target_link_libraries(lldMachOTests
+target_link_libraries(lldMachOOldTests
   PRIVATE
   lldDriver
-  lldMachO
+  lldMachOOld
   lldYAML
   )
diff --git a/llvm/utils/gn/secondary/lld/MachO/BUILD.gn b/llvm/utils/gn/secondary/lld/MachO/BUILD.gn
@@ -1,12 +1,12 @@
 import("//llvm/utils/TableGen/tablegen.gni")
 
 tablegen("Options") {
-  visibility = [ ":MachO2" ]
+  visibility = [ ":MachO" ]
   args = [ "-gen-opt-parser-defs" ]
 }
 
-static_library("MachO2") {
-  output_name = "lldMachO2"
+static_library("MachO") {
+  output_name = "lldMachO"
   configs += [ "//llvm/utils/gn/build:lld_code" ]
   deps = [
     ":Options",
diff --git a/llvm/utils/gn/secondary/lld/lib/Driver/BUILD.gn b/llvm/utils/gn/secondary/lld/lib/Driver/BUILD.gn
@@ -13,7 +13,7 @@ static_library("Driver") {
     "//lld/Common",
     "//lld/lib/Core",
     "//lld/lib/ReaderWriter",
-    "//lld/lib/ReaderWriter/MachO",
+    "//lld/lib/ReaderWriter/MachO:MachOOld",
     "//lld/lib/ReaderWriter/YAML",
     "//llvm/lib/Option",
     "//llvm/lib/Support",
diff --git a/llvm/utils/gn/secondary/lld/lib/ReaderWriter/MachO/BUILD.gn b/llvm/utils/gn/secondary/lld/lib/ReaderWriter/MachO/BUILD.gn
@@ -1,5 +1,5 @@
-static_library("MachO") {
-  output_name = "lldMachO"
+static_library("MachOOld") {
+  output_name = "lldMachOOld"
   configs += [ "//llvm/utils/gn/build:lld_code" ]
   deps = [
     "//lld/lib/Core",
diff --git a/llvm/utils/gn/secondary/lld/tools/lld/BUILD.gn b/llvm/utils/gn/secondary/lld/tools/lld/BUILD.gn
@@ -29,7 +29,7 @@ executable("lld") {
   deps = [
     "//lld/COFF",
     "//lld/ELF",
-    "//lld/MachO:MachO2",
+    "//lld/MachO:MachO",
     "//lld/MinGW",
     "//lld/lib/Driver",
     "//lld/wasm",
diff --git a/llvm/utils/gn/secondary/lld/unittests/BUILD.gn b/llvm/utils/gn/secondary/lld/unittests/BUILD.gn
@@ -1,7 +1,7 @@
 group("unittests") {
   deps = [
     "DriverTests",
-    "MachOTests",
+    "MachOTests:MachOOldTests",
   ]
   testonly = true
 }
diff --git a/llvm/utils/gn/secondary/lld/unittests/DriverTests/BUILD.gn b/llvm/utils/gn/secondary/lld/unittests/DriverTests/BUILD.gn
@@ -4,7 +4,7 @@ unittest("DriverTests") {
   configs += [ "//llvm/utils/gn/build:lld_code" ]
   deps = [
     "//lld/lib/Driver",
-    "//lld/lib/ReaderWriter/MachO",
+    "//lld/lib/ReaderWriter/MachO:MachOOld",
   ]
   sources = [ "DarwinLdDriverTest.cpp" ]
 }
diff --git a/llvm/utils/gn/secondary/lld/unittests/MachOTests/BUILD.gn b/llvm/utils/gn/secondary/lld/unittests/MachOTests/BUILD.gn
@@ -1,10 +1,10 @@
 import("//llvm/utils/unittest/unittest.gni")
 
-unittest("MachOTests") {
+unittest("MachOOldTests") {
   configs += [ "//llvm/utils/gn/build:lld_code" ]
   deps = [
     "//lld/lib/Driver",
-    "//lld/lib/ReaderWriter/MachO",
+    "//lld/lib/ReaderWriter/MachO:MachOOld",
     "//lld/lib/ReaderWriter/YAML",
   ]
   sources = [

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ add_lld_library(lldDriver`
`15`	`15`	`LINK_LIBS`
`16`	`16`	`lldCommon`
`17`	`17`	`lldCore`
`18`		`- lldMachO`
	`18`	`+ lldMachOOld`
`19`	`19`	`lldReaderWriter`
`20`	`20`	`lldYAML`
`21`	`21`	`)`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-add_lld_library(lldMachO`
	`1`	`+add_lld_library(lldMachOOld`
`2`	`2`	`ArchHandler.cpp`
`3`	`3`	`ArchHandler_arm.cpp`
`4`	`4`	`ArchHandler_arm64.cpp`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ target_link_libraries(lld`
`15`	`15`	`lldCOFF`
`16`	`16`	`lldDriver`
`17`	`17`	`lldELF`
`18`		`- lldMachO2`
	`18`	`+ lldMachO`
`19`	`19`	`lldMinGW`
`20`	`20`	`lldWasm`
`21`	`21`	`)`
Original file line number	Diff line number	Diff line change
`@@ -5,5 +5,5 @@ add_lld_unittest(DriverTests`
`5`	`5`	`target_link_libraries(DriverTests`
`6`	`6`	`PRIVATE`
`7`	`7`	`lldDriver`
`8`		`- lldMachO`
	`8`	`+ lldMachOOld`
`9`	`9`	`)`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`group("unittests") {`
`2`	`2`	`deps = [`
`3`	`3`	`"DriverTests",`
`4`		`- "MachOTests",`
	`4`	`+ "MachOTests:MachOOldTests",`
`5`	`5`	`]`
`6`	`6`	`testonly = true`
`7`	`7`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ unittest("DriverTests") {`
`4`	`4`	`configs += [ "//llvm/utils/gn/build:lld_code" ]`
`5`	`5`	`deps = [`
`6`	`6`	`"//lld/lib/Driver",`
`7`		`- "//lld/lib/ReaderWriter/MachO",`
	`7`	`+ "//lld/lib/ReaderWriter/MachO:MachOOld",`
`8`	`8`	`]`
`9`	`9`	`sources = [ "DarwinLdDriverTest.cpp" ]`
`10`	`10`	`}`