revert MutableArrayRef back to vector

Author: kastiglione

lldb/include/lldb/Target/SwiftLanguageRuntime.h

@@ -256,11 +256,9 @@ class SwiftLanguageRuntime : public LanguageRuntime {
   llvm::Optional<unsigned> GetNumChildren(CompilerType type,
                                           ValueObject *valobj);
 
-  llvm::Optional<size_t>
-  GetIndexOfChildMemberWithName(CompilerType type, llvm::StringRef name,
-                                ExecutionContext *exe_ctx,
-                                bool omit_empty_base_classes,
-                                llvm::MutableArrayRef<uint32_t> child_indexes);
+  llvm::Optional<size_t> GetIndexOfChildMemberWithName(
+      CompilerType type, llvm::StringRef name, ExecutionContext *exe_ctx,
+      bool omit_empty_base_classes, std::vector<uint32_t> &child_indexes);
 
   /// Ask Remote Mirrors about a child of a composite type.
   CompilerType GetChildCompilerTypeAtIndex(

lldb/source/Target/SwiftLanguageRuntime.cpp

@@ -257,11 +257,9 @@ class SwiftLanguageRuntimeStub {
     return {};
   }
 
-  llvm::Optional<size_t>
-  GetIndexOfChildMemberWithName(CompilerType type, llvm::StringRef name,
-                                ExecutionContext *exe_ctx,
-                                bool omit_empty_base_classes,
-                                llvm::MutableArrayRef<uint32_t> child_indexes) {
+  llvm::Optional<size_t> GetIndexOfChildMemberWithName(
+      CompilerType type, llvm::StringRef name, ExecutionContext *exe_ctx,
+      bool omit_empty_base_classes, std::vector<uint32_t> &child_indexes) {
     STUB_LOG();
     return {};
   }
@@ -2155,8 +2153,7 @@ SwiftLanguageRuntime::GetNumChildren(CompilerType type, ValueObject *valobj) {
 
 llvm::Optional<size_t> SwiftLanguageRuntime::GetIndexOfChildMemberWithName(
     CompilerType type, llvm::StringRef name, ExecutionContext *exe_ctx,
-    bool omit_empty_base_classes,
-    llvm::MutableArrayRef<uint32_t> child_indexes) {
+    bool omit_empty_base_classes, std::vector<uint32_t> &child_indexes) {
   FORWARD(GetIndexOfChildMemberWithName, type, name, exe_ctx,
           omit_empty_base_classes, child_indexes);
 }

lldb/source/Target/SwiftLanguageRuntimeDynamicTypeResolution.cpp

@@ -1144,8 +1144,7 @@ GetTypeFromTypeRef(TypeSystemSwiftTypeRef &ts,
 
 llvm::Optional<size_t> SwiftLanguageRuntimeImpl::GetIndexOfChildMemberWithName(
     CompilerType type, llvm::StringRef name, ExecutionContext *exe_ctx,
-    bool omit_empty_base_classes,
-    llvm::MutableArrayRef<uint32_t> child_indexes) {
+    bool omit_empty_base_classes, std::vector<uint32_t> &child_indexes) {
   return {};
 }
 

lldb/source/Target/SwiftLanguageRuntimeImpl.h

@@ -120,11 +120,9 @@ class SwiftLanguageRuntimeImpl {
   llvm::Optional<unsigned> GetNumChildren(CompilerType type,
                                           ValueObject *valobj);
 
-  llvm::Optional<size_t>
-  GetIndexOfChildMemberWithName(CompilerType type, llvm::StringRef name,
-                                ExecutionContext *exe_ctx,
-                                bool omit_empty_base_classes,
-                                llvm::MutableArrayRef<uint32_t> child_indexes);
+  llvm::Optional<size_t> GetIndexOfChildMemberWithName(
+      CompilerType type, llvm::StringRef name, ExecutionContext *exe_ctx,
+      bool omit_empty_base_classes, std::vector<uint32_t> &child_indexes);
 
   CompilerType GetChildCompilerTypeAtIndex(
       CompilerType type, size_t idx, bool transparent_pointers,