Skip to content

Commit 7bd9be2

Browse files
[Driver] Use heterogenous lookups with std::set (NFC) (llvm#115259)
Heterogenous lookups allow us to call find with StringRef, avoiding a temporary heap allocation of std::string.
1 parent ef73533 commit 7bd9be2

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

clang/lib/Driver/ToolChains/HIPUtility.cpp

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -148,8 +148,8 @@ class HIPUndefinedFatBinSymbols {
148148
bool Verbose;
149149
std::set<std::string> FatBinSymbols;
150150
std::set<std::string> GPUBinHandleSymbols;
151-
std::set<std::string> DefinedFatBinSymbols;
152-
std::set<std::string> DefinedGPUBinHandleSymbols;
151+
std::set<std::string, std::less<>> DefinedFatBinSymbols;
152+
std::set<std::string, std::less<>> DefinedGPUBinHandleSymbols;
153153
const std::string FatBinPrefix = "__hip_fatbin";
154154
const std::string GPUBinHandlePrefix = "__hip_gpubin_handle";
155155

@@ -260,11 +260,10 @@ class HIPUndefinedFatBinSymbols {
260260

261261
// Add undefined symbols if they are not in the defined sets
262262
if (isFatBinSymbol &&
263-
DefinedFatBinSymbols.find(Name.str()) == DefinedFatBinSymbols.end())
263+
DefinedFatBinSymbols.find(Name) == DefinedFatBinSymbols.end())
264264
FatBinSymbols.insert(Name.str());
265-
else if (isGPUBinHandleSymbol &&
266-
DefinedGPUBinHandleSymbols.find(Name.str()) ==
267-
DefinedGPUBinHandleSymbols.end())
265+
else if (isGPUBinHandleSymbol && DefinedGPUBinHandleSymbols.find(Name) ==
266+
DefinedGPUBinHandleSymbols.end())
268267
GPUBinHandleSymbols.insert(Name.str());
269268
}
270269
}

0 commit comments

Comments
 (0)