Revert "Adorn __call_once_proxy with inline and _LIBCPP_INLINE_VISIBILITY"

bogner · bogner · commit 8335dd314f36 · 2017-01-31T01:26:09.000Z
While this change didn't really hurt, it does lead to spurious
warnings about not being able to override weak symbols if you end up
linking objects built with this change to ones built without it.
Furthermore, since __call_once_proxy is called indirectly anyway it
doesn't actually inline ever.

Longer term, it would probably make sense to give this symbol internal
visibility instead.

This reverts r291497

llvm-svn: 293581
diff --git a/libcxx/include/mutex b/libcxx/include/mutex
@@ -559,7 +559,6 @@ public:
 #endif
 
 template <class _Fp>
-inline _LIBCPP_INLINE_VISIBILITY
 void
 __call_once_proxy(void* __vp)
 {

Original file line number	Diff line number	Diff line change
`@@ -559,7 +559,6 @@ public:`
`559`	`559`	`#endif`
`560`	`560`
`561`	`561`	`template <class _Fp>`
`562`		`-inline _LIBCPP_INLINE_VISIBILITY`
`563`	`562`	`void`
`564`	`563`	`__call_once_proxy(void* __vp)`
`565`	`564`	`{`