Skip to content

Commit 83cdcd5

Browse files
authored
[MLIR/linalg] Update arg name of generalizeNamedOp in Transforms.h (llvm#123679)
`Generalization.cpp:53` ```cpp FailureOr<GenericOp> mlir::linalg::generalizeNamedOp(RewriterBase &rewriter, LinalgOp linalgOp) { if (failed(generalizeNamedOpPrecondition(linalgOp))) return rewriter.notifyMatchFailure(linalgOp, "preconditions not met"); SmallVector<Value> inputs = linalgOp.getDpsInputs(); ValueRange outputs = linalgOp.getDpsInits(); SmallVector<AffineMap> indexingMaps = linalgOp.getIndexingMapsArray(); SmallVector<utils::IteratorType> iterators = linalgOp.getIteratorTypesArray(); SmallVector<Type> resultTypes = linalgOp.hasPureTensorSemantics() ? TypeRange(ValueRange(outputs)) : TypeRange{}; ... ``` `generalizeNamedOp` in `Generalization.cpp` has a different arg name than `generalizeNamedOp` in `Transforms.h` Sync to use `linalgOp`
1 parent 635e154 commit 83cdcd5

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -699,11 +699,11 @@ FailureOr<GenericOp> interchangeGenericOp(RewriterBase &rewriter,
699699
GenericOp genericOp,
700700
ArrayRef<unsigned> interchangeVector);
701701

702-
/// Create a GenericOp from the given named operation `namedOp` and replace
703-
/// namedOp.
704-
/// Return failure if `namedOp` is a GenericOp or misses a region builder.
702+
/// Create a GenericOp from the given named operation `linalgOp` and replace
703+
/// the given `linalgOp`.
704+
/// Return failure if `linalgOp` is a GenericOp or misses a region builder.
705705
FailureOr<GenericOp> generalizeNamedOp(RewriterBase &rewriter,
706-
LinalgOp namedOp);
706+
LinalgOp linalgOp);
707707

708708
/// Create a namedOp from the given GenericOp and replace the GenericOp.
709709
/// Currently we can specialize only trivial linalg copy operations.

0 commit comments

Comments
 (0)