Skip to content

Commit 8a1084a

Browse files
committed
[asan][test] XFAIL Posix/no_asan_gen_globals.c on Solaris
`Posix/no_asan_gen_globals.c` currently `FAIL`s on Solaris: $ nm no_asan_gen_globals.c.tmp.exe | grep ___asan_gen_ 0809696a r .L___asan_gen_.1 0809a4cd r .L___asan_gen_.2 080908e2 r .L___asan_gen_.4 0809a4cd r .L___asan_gen_.5 0809a529 r .L___asan_gen_.7 0809a4cd r .L___asan_gen_.8 As detailed in Bug 47607, there are two factors here: - `clang` plays games by emitting some local labels into the symbol table. When instead one uses `-fno-integrated-as` to have `gas` create the object files, they don't land in the objects in the first place. - Unlike GNU `ld`, the Solaris `ld` doesn't support support `-X`/`--discard-locals` but instead relies on the assembler to follow its specification and not emit local labels. Therefore this patch `XFAIL`s the test on Solaris. Tested on `amd64-pc-solaris2.11` and `x86_64-pc-linux-gnu`. Differential Revision: https://reviews.llvm.org/D88218
1 parent d1d7fc9 commit 8a1084a

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

compiler-rt/test/asan/TestCases/Posix/no_asan_gen_globals.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
// FIXME: https://code.google.com/p/address-sanitizer/issues/detail?id=316
22
// XFAIL: android
3+
// Bug 47607
4+
// XFAIL: solaris
35
// Make sure ___asan_gen_* strings do not end up in the symbol table.
46

57
// RUN: %clang_asan %s -o %t.exe

0 commit comments

Comments
 (0)