Skip to content

Commit 8bf986c

Browse files
committed
Revert "Work around outdated system header files on Amazon Linux"
This reverts commit 3ffe24f. (cherry picked from commit 2d5f691)
1 parent c67ee40 commit 8bf986c

File tree

3 files changed

+1
-45
lines changed

3 files changed

+1
-45
lines changed

lldb/cmake/modules/LLDBConfig.cmake

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -345,19 +345,4 @@ if ((CMAKE_SYSTEM_NAME MATCHES "Android") AND LLVM_BUILD_STATIC AND
345345
add_definitions(-DANDROID_USE_ACCEPT_WORKAROUND)
346346
endif()
347347

348-
if (CMAKE_SYSTEM_NAME MATCHES "Linux")
349-
check_cxx_source_compiles(
350-
"#include <asm/ptrace.h>
351-
struct user_sve_header hdr;
352-
int main(void){return 0;}
353-
"
354-
user_sve_header_available)
355-
if(user_sve_header_available)
356-
set(LLDB_HAVE_USER_SVE_HEADER ON)
357-
message(STATUS "AArch64 SVE support enabled.")
358-
else()
359-
message(STATUS "AArch64 SVE support disabled.")
360-
endif()
361-
endif()
362-
363348
include(LLDBGenerateConfig)

lldb/include/lldb/Host/Config.h.cmake

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,6 @@
4747

4848
#cmakedefine01 LLDB_EMBED_PYTHON_HOME
4949

50-
#cmakedefine01 LLDB_HAVE_USER_SVE_HEADER
51-
5250
#cmakedefine LLDB_PYTHON_HOME R"(${LLDB_PYTHON_HOME})"
5351

5452
#define LLDB_LIBDIR_SUFFIX "${LLVM_LIBDIR_SUFFIX}"

lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp

Lines changed: 1 addition & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,7 @@ NativeRegisterContextLinux::CreateHostNativeRegisterContextLinux(
6060
case llvm::Triple::aarch64: {
6161
// Configure register sets supported by this AArch64 target.
6262
// Read SVE header to check for SVE support.
63-
#if LLDB_HAVE_USER_SVE_HEADER
6463
struct user_sve_header sve_header;
65-
#else
66-
struct {} sve_header;
67-
#endif
6864
struct iovec ioVec;
6965
ioVec.iov_base = &sve_header;
7066
ioVec.iov_len = sizeof(sve_header);
@@ -209,21 +205,13 @@ NativeRegisterContextLinux_arm64::ReadRegister(const RegisterInfo *reg_info,
209205
if (reg == GetRegisterInfo().GetRegNumFPSR()) {
210206
sve_reg_num = reg;
211207
if (m_sve_state == SVEState::Full)
212-
#if LLDB_HAVE_USER_SVE_HEADER
213208
offset = sve::PTraceFPSROffset(sve::vq_from_vl(m_sve_header.vl));
214-
#else
215-
offset = 0;
216-
#endif
217209
else if (m_sve_state == SVEState::FPSIMD)
218210
offset = sve::ptrace_fpsimd_offset + (32 * 16);
219211
} else if (reg == GetRegisterInfo().GetRegNumFPCR()) {
220212
sve_reg_num = reg;
221213
if (m_sve_state == SVEState::Full)
222-
#if LLDB_HAVE_USER_SVE_HEADER
223214
offset = sve::PTraceFPCROffset(sve::vq_from_vl(m_sve_header.vl));
224-
#else
225-
offset = 0;
226-
#endif
227215
else if (m_sve_state == SVEState::FPSIMD)
228216
offset = sve::ptrace_fpsimd_offset + (32 * 16) + 4;
229217
} else {
@@ -351,21 +339,13 @@ Status NativeRegisterContextLinux_arm64::WriteRegister(
351339
if (reg == GetRegisterInfo().GetRegNumFPSR()) {
352340
sve_reg_num = reg;
353341
if (m_sve_state == SVEState::Full)
354-
#if LLDB_HAVE_USER_SVE_HEADER
355342
offset = sve::PTraceFPSROffset(sve::vq_from_vl(m_sve_header.vl));
356-
#else
357-
offset = 0;
358-
#endif
359343
else if (m_sve_state == SVEState::FPSIMD)
360344
offset = sve::ptrace_fpsimd_offset + (32 * 16);
361345
} else if (reg == GetRegisterInfo().GetRegNumFPCR()) {
362346
sve_reg_num = reg;
363347
if (m_sve_state == SVEState::Full)
364-
#if LLDB_HAVE_USER_SVE_HEADER
365348
offset = sve::PTraceFPCROffset(sve::vq_from_vl(m_sve_header.vl));
366-
#else
367-
offset = 0;
368-
#endif
369349
else if (m_sve_state == SVEState::FPSIMD)
370350
offset = sve::ptrace_fpsimd_offset + (32 * 16) + 4;
371351
} else {
@@ -393,7 +373,6 @@ Status NativeRegisterContextLinux_arm64::WriteRegister(
393373
if (GetRegisterInfo().IsSVERegVG(reg)) {
394374
uint64_t vg_value = reg_value.GetAsUInt64();
395375

396-
#if LLDB_HAVE_USER_SVE_HEADER
397376
if (sve_vl_valid(vg_value * 8)) {
398377
if (m_sve_header_is_valid && vg_value == GetSVERegVG())
399378
return error;
@@ -407,11 +386,9 @@ Status NativeRegisterContextLinux_arm64::WriteRegister(
407386
if (m_sve_header_is_valid && vg_value == GetSVERegVG())
408387
return error;
409388
}
410-
#endif
389+
411390
return Status("SVE vector length update failed.");
412-
#if LLDB_HAVE_USER_SVE_HEADER
413391
}
414-
#endif
415392

416393
// If target supports SVE but currently in FPSIMD mode.
417394
if (m_sve_state == SVEState::FPSIMD) {
@@ -940,22 +917,18 @@ void NativeRegisterContextLinux_arm64::ConfigureRegisterContext() {
940917
if (error.Success()) {
941918
// If SVE is enabled thread can switch between SVEState::FPSIMD and
942919
// SVEState::Full on every stop.
943-
#if LLDB_HAVE_USER_SVE_HEADER
944920
if ((m_sve_header.flags & sve::ptrace_regs_mask) ==
945921
sve::ptrace_regs_fpsimd)
946922
m_sve_state = SVEState::FPSIMD;
947923
else if ((m_sve_header.flags & sve::ptrace_regs_mask) ==
948924
sve::ptrace_regs_sve)
949925
m_sve_state = SVEState::Full;
950-
#endif
951926

952927
// On every stop we configure SVE vector length by calling
953928
// ConfigureVectorLength regardless of current SVEState of this thread.
954929
uint32_t vq = RegisterInfoPOSIX_arm64::eVectorQuadwordAArch64SVE;
955-
#if LLDB_HAVE_USER_SVE_HEADER
956930
if (sve_vl_valid(m_sve_header.vl))
957931
vq = sve::vq_from_vl(m_sve_header.vl);
958-
#endif
959932

960933
GetRegisterInfo().ConfigureVectorLength(vq);
961934
m_sve_ptrace_payload.resize(sve::PTraceSize(vq, sve::ptrace_regs_sve));

0 commit comments

Comments
 (0)