[lldb] Add complete flag to Swift Task summary formatter (#10311)

Update the Task summary formatter to indicate when a task is complete.

rdar://147448235

Author: kastiglione

lldb/source/Plugins/Language/Swift/SwiftFormatters.cpp

@@ -794,6 +794,7 @@ class TaskSyntheticFrontEnd : public SyntheticChildrenFrontEnd {
       "isStatusRecordLocked",
       "isEscalated",
       "isEnqueued",
+      "isComplete",
       "isRunning",
       // clang-format on
   };
@@ -881,7 +882,9 @@ class TaskSyntheticFrontEnd : public SyntheticChildrenFrontEnd {
       RETURN_CHILD(m_is_escalated_sp, isEscalated, bool_type);
     case 11:
       RETURN_CHILD(m_is_enqueued_sp, isEnqueued, bool_type);
-    case 12: {
+    case 12:
+      RETURN_CHILD(m_is_complete_sp, isComplete, bool_type);
+    case 13: {
       if (m_task_info.hasIsRunning)
         RETURN_CHILD(m_is_running_sp, isRunning, bool_type);
       return {};
@@ -915,7 +918,8 @@ class TaskSyntheticFrontEnd : public SyntheticChildrenFrontEnd {
                 m_is_child_task_sp, m_is_future_sp, m_is_group_child_task_sp,
                 m_is_async_let_task_sp, m_is_cancelled_sp,
                 m_is_status_record_locked_sp, m_is_escalated_sp,
-                m_is_enqueued_sp, m_child_tasks_sp, m_is_running_sp})
+                m_is_enqueued_sp, m_is_complete_sp, m_child_tasks_sp,
+                m_is_running_sp})
             child.reset();
         }
       }
@@ -978,6 +982,7 @@ class TaskSyntheticFrontEnd : public SyntheticChildrenFrontEnd {
   ValueObjectSP m_is_status_record_locked_sp;
   ValueObjectSP m_is_escalated_sp;
   ValueObjectSP m_is_enqueued_sp;
+  ValueObjectSP m_is_complete_sp;
   ValueObjectSP m_child_tasks_sp;
   ValueObjectSP m_is_running_sp;
 };
@@ -1647,6 +1652,7 @@ bool lldb_private::formatters::swift::TaskPriority_SummaryProvider(
 }
 
 static const std::pair<StringRef, StringRef> TASK_FLAGS[] = {
+    {"isComplete", "complete"},
     {"isRunning", "running"},
     {"isCancelled", "cancelled"},
     {"isEscalated", "escalated"},

lldb/source/Plugins/LanguageRuntime/Swift/ReflectionContext.cpp

@@ -409,6 +409,7 @@ class TargetReflectionContext : public ReflectionContextInterface {
     result.hasIsRunning = task_info.HasIsRunning;
     result.isRunning = task_info.IsRunning;
     result.isEnqueued = task_info.IsEnqueued;
+    result.isComplete = task_info.IsComplete;
     result.id = task_info.Id;
     result.kind = task_info.Kind;
     result.enqueuePriority = task_info.EnqueuePriority;

lldb/source/Plugins/LanguageRuntime/Swift/ReflectionContextInterface.h

@@ -168,6 +168,7 @@ class ReflectionContextInterface {
     bool hasIsRunning = false;
     bool isRunning = false;
     bool isEnqueued = false;
+    bool isComplete = false;
     uint64_t id = 0;
     uint32_t kind = 0;
     uint32_t enqueuePriority = 0;

lldb/test/API/lang/swift/async/formatters/task/complete/Makefile

@@ -0,0 +1,3 @@
+SWIFT_SOURCES := main.swift
+SWIFTFLAGS_EXTRAS := -parse-as-library
+include Makefile.rules

lldb/test/API/lang/swift/async/formatters/task/complete/TestSwiftTaskComplete.py

@@ -0,0 +1,16 @@
+import textwrap
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class TestCase(TestBase):
+
+    @swiftTest
+    def test(self):
+        self.build()
+        lldbutil.run_to_source_breakpoint(
+            self, "break here", lldb.SBFileSpec("main.swift")
+        )
+        self.expect("v task", substrs=["flags:complete"])

lldb/test/API/lang/swift/async/formatters/task/complete/main.swift

@@ -0,0 +1,7 @@
+@main struct Main {
+    static func main() async {
+        let task = Task { return 15 }
+        _ = await task.value
+        print("break here")
+    }
+}