Skip to content

Commit 8d98e2e

Browse files
authored
Merge pull request #3626 from apple/jdevlieghere/AppleSilicon
Fix and re-enable some tests on Apple Silicon
2 parents dcc7698 + 6976b2b commit 8d98e2e

File tree

6 files changed

+8
-9
lines changed

6 files changed

+8
-9
lines changed

lldb/packages/Python/lldbsuite/test/lldbtest.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1297,7 +1297,8 @@ def getCPUInfo(self):
12971297

12981298
def isAArch64(self):
12991299
"""Returns true if the architecture is AArch64."""
1300-
return self.getArchitecture().lower() == "aarch64"
1300+
arch = self.getArchitecture().lower()
1301+
return arch in ["aarch64", "arm64", "arm64e"]
13011302

13021303
def isAArch64SVE(self):
13031304
return self.isAArch64() and "sve" in self.getCPUInfo()

lldb/test/API/functionalities/return-value/TestReturnValue.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,10 @@ def affected_by_pr44132(self):
2222
return (self.getArchitecture() in ["aarch64", "arm"] and
2323
self.getPlatform() in ["freebsd", "linux"])
2424

25-
# ABIMacOSX_arm can't fetch simple values inside a structure
25+
# ABIMacOSX_arm(64) can't fetch simple values inside a structure
2626
def affected_by_radar_34562999(self):
27-
return (self.getArchitecture() == 'armv7' or self.getArchitecture() == 'armv7k') and self.platformIsDarwin()
27+
arch = self.getArchitecture().lower()
28+
return arch in ['arm64', 'arm64e', 'armv7', 'armv7k'] and self.platformIsDarwin()
2829

2930
@expectedFailureAll(oslist=["freebsd"], archs=["i386"],
3031
bugnumber="llvm.org/pr48376")

lldb/test/API/functionalities/tsan/swift-access-race/TestTsanSwiftAccessRace.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ class TsanSwiftAccessRaceTestCase(lldbtest.TestBase):
3030
@skipIfLinux
3131
@skipUnlessSwiftThreadSanitizer
3232
@skipIfAsan # This test does not behave reliable with an ASANified LLDB.
33-
@expectedFailureAll(archs=['arm64'])
3433
def test_tsan_swift(self):
3534
self.build()
3635
self.do_test()

lldb/test/API/functionalities/tsan/swift/TestTsanSwift.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ class TsanSwiftTestCase(lldbtest.TestBase):
2929
@skipIfLinux
3030
@skipUnlessSwiftThreadSanitizer
3131
@skipIfAsan # This test does not behave reliable with an ASANified LLDB.
32-
@expectedFailureAll(archs=['arm64'])
3332
def test_tsan_swift(self):
3433
self.build()
3534
self.do_test()

lldb/test/API/lang/swift/multi_optionals/TestMultiOptionals.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,4 @@
1212
import lldbsuite.test.lldbinline as lldbinline
1313
from lldbsuite.test.decorators import *
1414

15-
lldbinline.MakeInlineTest(__file__, globals(), decorators=[swiftTest,
16-
expectedFailureAll(archs=['arm64', 'arm64e', 'arm64_32'], bugnumber="<rdar://problem/57854589>")])
17-
15+
lldbinline.MakeInlineTest(__file__, globals(), decorators=[swiftTest])

lldb/test/API/macosx/macCatalyst/Makefile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
C_SOURCES := main.c
22

3-
CFLAGS_EXTRAS := -target $(ARCH)-apple-ios13.0-macabi
3+
override TRIPLE := $(ARCH)-apple-ios13.1-macabi
4+
CFLAGS_EXTRAS := -target $(TRIPLE)
45

56
# FIXME: rdar://problem/54986190
67
# There is a Clang driver change missing on llvm.org.

0 commit comments

Comments
 (0)