Skip to content

Commit 8dcb8ea

Browse files
committed
[libc++] Remove support for .fail.cpp tests
We want to move away from those tests and towards explicit .verify.cpp tests, since those have a simpler model. Differential Revision: https://reviews.llvm.org/D153982
1 parent 14858cf commit 8dcb8ea

File tree

7 files changed

+0
-119
lines changed

7 files changed

+0
-119
lines changed

libcxx/test/libcxx/selftest/fail.cpp/compile-failure.fail.cpp

Lines changed: 0 additions & 15 deletions
This file was deleted.

libcxx/test/libcxx/selftest/fail.cpp/compile-success.fail.cpp

Lines changed: 0 additions & 16 deletions
This file was deleted.

libcxx/test/libcxx/selftest/fail.cpp/no-diagnostics-unmarked.fail.cpp

Lines changed: 0 additions & 19 deletions
This file was deleted.

libcxx/test/libcxx/selftest/fail.cpp/no-diagnostics.fail.cpp

Lines changed: 0 additions & 14 deletions
This file was deleted.

libcxx/test/libcxx/selftest/fail.cpp/right-diagnostic.fail.cpp

Lines changed: 0 additions & 17 deletions
This file was deleted.

libcxx/test/libcxx/selftest/fail.cpp/wrong-diagnostic.fail.cpp

Lines changed: 0 additions & 18 deletions
This file was deleted.

libcxx/utils/libcxx/test/format.py

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -218,11 +218,6 @@ class CxxStandardLibraryTest(lit.formats.FileBasedTest):
218218
automatically marked as UNSUPPORTED if the compiler
219219
does not support Clang-verify.
220220
221-
FOO.fail.cpp - Compiled with clang-verify if clang-verify is
222-
supported, and equivalent to a .compile.fail.cpp
223-
test otherwise. This is supported only for backwards
224-
compatibility with the test suite.
225-
226221
227222
Substitution requirements
228223
===============================
@@ -367,21 +362,6 @@ def execute(self, test, litConfig):
367362
"%dbg(EXECUTED AS) %{exec} %t.exe",
368363
]
369364
return self._executeShTest(test, litConfig, steps)
370-
# This is like a .verify.cpp test when clang-verify is supported,
371-
# otherwise it's like a .compile.fail.cpp test. This is only provided
372-
# for backwards compatibility with the test suite.
373-
elif filename.endswith(".fail.cpp"):
374-
if supportsVerify:
375-
steps = [
376-
"%dbg(COMPILED WITH) %{{cxx}} %s %{{flags}} %{{compile_flags}} -fsyntax-only -Wno-error {}".format(
377-
VERIFY_FLAGS
378-
)
379-
]
380-
else:
381-
steps = [
382-
"%dbg(COMPILED WITH) ! %{cxx} %s %{flags} %{compile_flags} -fsyntax-only"
383-
]
384-
return self._executeShTest(test, litConfig, steps)
385365
else:
386366
return lit.Test.Result(
387367
lit.Test.UNRESOLVED, "Unknown test suffix for '{}'".format(filename)

0 commit comments

Comments
 (0)