[lldb] Remove pointless assign to found_suffix (NFC)

JDevlieghere · JDevlieghere · commit 9097ef84ce59 · 2020-08-05T22:54:03.000-07:00
diff --git a/lldb/source/Utility/Args.cpp b/lldb/source/Utility/Args.cpp
@@ -640,7 +640,6 @@ void OptionsWithRaw::SetFromString(llvm::StringRef arg_string) {
   }
 
   bool found_suffix = false;
-
   while (!arg_string.empty()) {
     // The length of the prefix before parsing.
     std::size_t prev_prefix_length = original_args.size() - arg_string.size();
@@ -679,10 +678,8 @@ void OptionsWithRaw::SetFromString(llvm::StringRef arg_string) {
   }
 
   // If we didn't find a suffix delimiter, the whole string is the raw suffix.
-  if (!found_suffix) {
-    found_suffix = true;
+  if (!found_suffix)
     m_suffix = std::string(original_args);
-  }
 }
 
 void llvm::yaml::MappingTraits<Args::ArgEntry>::mapping(IO &io,

Original file line number	Diff line number	Diff line change
`@@ -640,7 +640,6 @@ void OptionsWithRaw::SetFromString(llvm::StringRef arg_string) {`
`640`	`640`	`}`
`641`	`641`
`642`	`642`	`bool found_suffix = false;`
`643`		`-`
`644`	`643`	`while (!arg_string.empty()) {`
`645`	`644`	`// The length of the prefix before parsing.`
`646`	`645`	`std::size_t prev_prefix_length = original_args.size() - arg_string.size();`
`@@ -679,10 +678,8 @@ void OptionsWithRaw::SetFromString(llvm::StringRef arg_string) {`
`679`	`678`	`}`
`680`	`679`
`681`	`680`	`// If we didn't find a suffix delimiter, the whole string is the raw suffix.`
`682`		`- if (!found_suffix) {`
`683`		`- found_suffix = true;`
	`681`	`+ if (!found_suffix)`
`684`	`682`	`m_suffix = std::string(original_args);`
`685`		`- }`
`686`	`683`	`}`
`687`	`684`
`688`	`685`	`void llvm::yaml::MappingTraits<Args::ArgEntry>::mapping(IO &io,`