Skip to content

Commit 935bbbb

Browse files
authored
[PPC] Remove missed cases of ppc-merge-string-pool (llvm#117626)
PPCMergeStringPool was replaced with GlobalMerge with commit aaa37d6. Some cases of option ppc-merge-string-pool were missed being removed.
1 parent 2a1a024 commit 935bbbb

File tree

6 files changed

+11
-16
lines changed

6 files changed

+11
-16
lines changed

llvm/lib/Target/PowerPC/PPCTargetMachine.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -99,11 +99,6 @@ static cl::opt<bool>
9999
cl::desc("Expand eligible cr-logical binary ops to branches"),
100100
cl::init(true), cl::Hidden);
101101

102-
static cl::opt<bool> MergeStringPool(
103-
"ppc-merge-string-pool",
104-
cl::desc("Merge all of the strings in a module into one pool"),
105-
cl::init(true), cl::Hidden);
106-
107102
static cl::opt<bool> EnablePPCGenScalarMASSEntries(
108103
"enable-ppc-gen-scalar-mass", cl::init(false),
109104
cl::desc("Enable lowering math functions to their corresponding MASS "

llvm/test/CodeGen/PowerPC/aix-xcoff-mergeable-str.ll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@
44
; tests for XCOFF object files.
55

66
; RUN: llc -verify-machineinstrs -mcpu=pwr4 -mattr=-altivec -xcoff-traceback-table=false \
7-
; RUN: -mtriple powerpc-ibm-aix-xcoff -data-sections=false -ppc-merge-string-pool=false \
7+
; RUN: -mtriple powerpc-ibm-aix-xcoff -data-sections=false \
88
; RUN: -global-merge-all-const=false < %s | FileCheck %s
99
; RUN: llc -verify-machineinstrs -mcpu=pwr4 -mattr=-altivec -xcoff-traceback-table=false \
10-
; RUN: -mtriple powerpc64-ibm-aix-xcoff -data-sections=false -ppc-merge-string-pool=false \
10+
; RUN: -mtriple powerpc64-ibm-aix-xcoff -data-sections=false \
1111
; RUN: -global-merge-all-const=false < %s | FileCheck %s
1212

1313
; RUN: llc -verify-machineinstrs -mcpu=pwr4 -mattr=-altivec -mtriple powerpc-ibm-aix-xcoff \
14-
; RUN: -xcoff-traceback-table=false -data-sections=false -ppc-merge-string-pool=false \
14+
; RUN: -xcoff-traceback-table=false -data-sections=false \
1515
; RUN: -global-merge-all-const=false -filetype=obj -o %t.o < %s
1616
; RUN: llvm-objdump -D %t.o | FileCheck --check-prefix=CHECKOBJ %s
1717

llvm/test/CodeGen/PowerPC/aix-xcoff-rodata.ll

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
1-
; RUN: llc -verify-machineinstrs -mcpu=pwr7 -mtriple powerpc-ibm-aix-xcoff -data-sections=false -ppc-merge-string-pool=false < %s | \
1+
; RUN: llc -verify-machineinstrs -mcpu=pwr7 -mtriple powerpc-ibm-aix-xcoff -data-sections=false < %s | \
22
; RUN: FileCheck --check-prefixes=CHECK,CHECK32 %s
3-
; RUN: llc -verify-machineinstrs -mcpu=pwr7 -mtriple powerpc64-ibm-aix-xcoff -data-sections=false -ppc-merge-string-pool=false < %s | \
3+
; RUN: llc -verify-machineinstrs -mcpu=pwr7 -mtriple powerpc64-ibm-aix-xcoff -data-sections=false < %s | \
44
; RUN: FileCheck --check-prefixes=CHECK,CHECK64 %s
55

6-
; RUN: llc -verify-machineinstrs -mcpu=pwr7 -mtriple powerpc-ibm-aix-xcoff -data-sections=false -ppc-merge-string-pool=false \
6+
; RUN: llc -verify-machineinstrs -mcpu=pwr7 -mtriple powerpc-ibm-aix-xcoff -data-sections=false \
77
; RUN: -filetype=obj -o %t.o < %s
88
; RUN: llvm-readobj --section-headers --file-header %t.o | \
99
; RUN: FileCheck --check-prefixes=OBJ,OBJ32 %s
1010
; RUN: llvm-readobj --syms %t.o | FileCheck --check-prefixes=SYMS,SYMS32 %s
1111
; RUN: llvm-objdump -D %t.o | FileCheck --check-prefix=DIS %s
1212

13-
; RUN: llc -verify-machineinstrs -mcpu=pwr7 -mtriple powerpc64-ibm-aix-xcoff -data-sections=false -ppc-merge-string-pool=false \
13+
; RUN: llc -verify-machineinstrs -mcpu=pwr7 -mtriple powerpc64-ibm-aix-xcoff -data-sections=false \
1414
; RUN: -filetype=obj -o %t64.o < %s
1515
; RUN: llvm-readobj --section-headers --file-header %t64.o | \
1616
; RUN: FileCheck --check-prefixes=OBJ,OBJ64 %s

llvm/test/CodeGen/PowerPC/aix-xcoff-used-with-stringpool.ll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
;; Test that the string pooling pass does not pool globals that are
1+
;; Test that the global merge pass does not pool globals that are
22
;; in llvm.used or in llvm.compiler.used.
33

44
; RUN: llc -verify-machineinstrs -mcpu=pwr8 -mtriple powerpc-ibm-aix-xcoff \

llvm/test/CodeGen/PowerPC/mergeable-string-pool-exceptions.ll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
@id = private unnamed_addr constant [4 x i8] c"@id\00", align 1
55
@id2 = private unnamed_addr constant [5 x i8] c"@id2\00", align 1
66

7-
; Higher-aligned dummy to make sure it is first in the string pool.
7+
; Higher-aligned dummy to make sure it is first in the global merge pool.
88
@dummy = private unnamed_addr constant [1 x i32] [i32 42], align 4
99

1010
define ptr @test1() personality ptr @__gnu_objc_personality_v0 {

llvm/test/CodeGen/PowerPC/mergeable-string-pool-tls.ll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -258,8 +258,8 @@ entry:
258258
ret void
259259
}
260260

261-
; Check the contents of the TLS data and the __ModuleStringPool structure to
262-
; check that TLS data has been skipped during string pool merging.
261+
; Check the contents of the TLS data and the _MergedGlobals structure to
262+
; check that TLS data has been skipped during global merge.
263263

264264
; CHECK64: .csect a[TL],2
265265
; CHECK64-NEXT: .lglobl a[TL]

0 commit comments

Comments
 (0)