Skip to content

Commit 94bda3a

Browse files
committed
[lldb] Removed scoped timer from ReadMemoryFromFileCache
`ReadMemoryFromFileCache` can be called at a high rate, and has fast execution. Signposts for high rate & brief duration can have a negative impact on tracing; emitting a high volume signposts can lead to blocking, affecting performance, and total volume makes human review of the trace harder because of the noise. Differential Revision: https://reviews.llvm.org/D121226
1 parent 3ca91ad commit 94bda3a

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

lldb/source/Target/Target.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1684,7 +1684,6 @@ bool Target::ModuleIsExcludedForUnconstrainedSearches(
16841684

16851685
size_t Target::ReadMemoryFromFileCache(const Address &addr, void *dst,
16861686
size_t dst_len, Status &error) {
1687-
LLDB_SCOPED_TIMER();
16881687
SectionSP section_sp(addr.GetSection());
16891688
if (section_sp) {
16901689
// If the contents of this section are encrypted, the on-disk file is

0 commit comments

Comments
 (0)