Skip to content

Commit 95de249

Browse files
committed
[Coverage] Assert that filenames in a TU are unique, NFC
llvm-svn: 372024
1 parent dd63b9f commit 95de249

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

llvm/include/llvm/ProfileData/Coverage/CoverageMappingWriter.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,7 @@ class CoverageFilenamesSectionWriter {
3030
ArrayRef<StringRef> Filenames;
3131

3232
public:
33-
CoverageFilenamesSectionWriter(ArrayRef<StringRef> Filenames)
34-
: Filenames(Filenames) {}
33+
CoverageFilenamesSectionWriter(ArrayRef<StringRef> Filenames);
3534

3635
/// Write encoded filenames to the given output stream.
3736
void write(raw_ostream &OS);

llvm/lib/ProfileData/Coverage/CoverageMappingWriter.cpp

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,16 @@
2424
using namespace llvm;
2525
using namespace coverage;
2626

27+
CoverageFilenamesSectionWriter::CoverageFilenamesSectionWriter(
28+
ArrayRef<StringRef> Filenames)
29+
: Filenames(Filenames) {
30+
#ifndef NDEBUG
31+
StringSet<> NameSet;
32+
for (StringRef Name : Filenames)
33+
assert(NameSet.insert(Name).second && "Duplicate filename");
34+
#endif
35+
}
36+
2737
void CoverageFilenamesSectionWriter::write(raw_ostream &OS) {
2838
encodeULEB128(Filenames.size(), OS);
2939
for (const auto &Filename : Filenames) {

0 commit comments

Comments
 (0)