Skip to content

Commit 97b9130

Browse files
committed
[clang] Disable assertion that can "easily happen"
Disable the assertion for getting a module ID for non-local, non-imported module. According to the FIXME this can "easily happen" and indeed, we're hitting this assertion regularly. Disable it until it can be properly investigated. rdar://99352728 Differential revision: https://reviews.llvm.org/D136290
1 parent af2b221 commit 97b9130

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

clang/lib/Serialization/ASTWriter.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2669,12 +2669,12 @@ unsigned ASTWriter::getLocalOrImportedSubmoduleID(const Module *Mod) {
26692669
}
26702670

26712671
unsigned ASTWriter::getSubmoduleID(Module *Mod) {
2672+
unsigned ID = getLocalOrImportedSubmoduleID(Mod);
26722673
// FIXME: This can easily happen, if we have a reference to a submodule that
26732674
// did not result in us loading a module file for that submodule. For
26742675
// instance, a cross-top-level-module 'conflict' declaration will hit this.
2675-
unsigned ID = getLocalOrImportedSubmoduleID(Mod);
2676-
assert((ID || !Mod) &&
2677-
"asked for module ID for non-local, non-imported module");
2676+
// assert((ID || !Mod) &&
2677+
// "asked for module ID for non-local, non-imported module");
26782678
return ID;
26792679
}
26802680

0 commit comments

Comments
 (0)