Merge pull request #8392 from adrian-prantl/cherry-pick-stable-20230725-Avoid-a-potential-exit-1-in-LLVMContext-diagnose-84992

[Cherry-pick into stable/20230725] Avoid a potential exit(1) in LLVMContext::diagnose()  (llvm#84992)

Author: adrian-prantl

lldb/source/Expression/IRExecutionUnit.cpp

@@ -233,18 +233,17 @@ struct IRExecDiagnosticHandler : public llvm::DiagnosticHandler {
   Status *err;
   IRExecDiagnosticHandler(Status *err) : err(err) {}
   bool handleDiagnostics(const llvm::DiagnosticInfo &DI) override {
-    if (DI.getKind() == llvm::DK_SrcMgr) {
+    if (DI.getSeverity() == llvm::DS_Error) {
       const auto &DISM = llvm::cast<llvm::DiagnosticInfoSrcMgr>(DI);
       if (err && err->Success()) {
         err->SetErrorToGenericError();
         err->SetErrorStringWithFormat(
-            "Inline assembly error: %s",
+            "IRExecution error: %s",
             DISM.getSMDiag().getMessage().str().c_str());
       }
-      return true;
     }
 
-    return false;
+    return true;
   }
 };
 } // namespace