Skip to content

Commit 9bace26

Browse files
committed
[lldb][NFC] Remove all setUp overrides that only call the parent implementation
Summary: A lot of our tests copied the setUp code from our TestSampleTest.py: ``` def setUp(self): # Call super's setUp(). TestBase.setUp(self) ``` This code does nothing unless we actually do any setUp work in there, so let's remove all these method definitions. Reviewers: labath, JDevlieghere Reviewed By: labath Subscribers: lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D71454
1 parent 3ca771b commit 9bace26

File tree

55 files changed

+0
-202
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+0
-202
lines changed

lldb/packages/Python/lldbsuite/test/api/listeners/TestListener.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,6 @@ class ListenToModuleLoadedEvents (TestBase):
1616

1717
mydir = TestBase.compute_mydir(__file__)
1818

19-
def setUp(self):
20-
# Call super's setUp().
21-
TestBase.setUp(self)
22-
2319
def test_receiving_breakpoint_added(self):
2420
"""Test that we get breakpoint added events, waiting on event classes on the debugger"""
2521
self.build()

lldb/packages/Python/lldbsuite/test/commands/apropos/basic/TestApropos.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,6 @@ class AproposTestCase(TestBase):
66

77
mydir = TestBase.compute_mydir(__file__)
88

9-
def setUp(self):
10-
TestBase.setUp(self)
11-
129
@no_debug_info_test
1310
def test_apropos(self):
1411
self.expect("apropos", error=True,

lldb/packages/Python/lldbsuite/test/commands/command/script/import/TestImport.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,6 @@ def test_import_command(self):
1818
"""Import some Python scripts by path and test them"""
1919
self.run_test()
2020

21-
def setUp(self):
22-
# Call super's setUp().
23-
TestBase.setUp(self)
24-
2521
def run_test(self):
2622
"""Import some Python scripts by path and test them."""
2723

lldb/packages/Python/lldbsuite/test/commands/command/script/import/rdar-12586188/TestRdar12586188.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,6 @@ def test_rdar12586188_command(self):
1818
"""Check that we handle an ImportError in a special way when command script importing files."""
1919
self.run_test()
2020

21-
def setUp(self):
22-
# Call super's setUp().
23-
TestBase.setUp(self)
24-
2521
def run_test(self):
2622
"""Check that we handle an ImportError in a special way when command script importing files."""
2723

lldb/packages/Python/lldbsuite/test/commands/disassemble/basic/TestFrameDisassemble.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,6 @@ def test_frame_disassemble(self):
2020
self.build()
2121
self.frame_disassemble_test()
2222

23-
def setUp(self):
24-
# Call super's setUp().
25-
TestBase.setUp(self)
26-
2723
def frame_disassemble_test(self):
2824
"""Sample test to ensure SBFrame::Disassemble produces SOME output"""
2925
exe = self.getBuildArtifact("a.out")

lldb/packages/Python/lldbsuite/test/commands/expression/calculator_mode/TestCalculatorMode.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@ class TestCalculatorMode(TestBase):
1414

1515
mydir = TestBase.compute_mydir(__file__)
1616

17-
def setUp(self):
18-
# Call super's setUp().
19-
TestBase.setUp(self)
20-
2117
def test__calculator_mode(self):
2218
"""Test calling expressions in the dummy target."""
2319
self.expect("expression 11 + 22", "11 + 22 didn't get the expected result", substrs=["33"])

lldb/packages/Python/lldbsuite/test/commands/expression/dont_allow_jit/TestAllowJIT.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,6 @@ def test_allow_jit_options(self):
3030
self.main_source_file = lldb.SBFileSpec("main.c")
3131
self.expr_options_test()
3232

33-
def setUp(self):
34-
# Call super's setUp().
35-
TestBase.setUp(self)
36-
3733
def expr_cmd_test(self):
3834
(target, process, thread, bkpt) = lldbutil.run_to_source_breakpoint(self,
3935
"Set a breakpoint here", self.main_source_file)

lldb/packages/Python/lldbsuite/test/commands/expression/entry-bp/TestExprEntryBP.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,5 +30,3 @@ def test_expr_entry_bp(self):
3030
self.assertTrue(result.IsValid(), "Can't evaluate expression")
3131
self.assertEqual(8, result.GetValueAsSigned())
3232

33-
def setUp(self):
34-
TestBase.setUp(self)

lldb/packages/Python/lldbsuite/test/commands/expression/persistent_ptr_update/TestPersistentPtrUpdate.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,6 @@ class PersistentPtrUpdateTestCase(TestBase):
1313

1414
mydir = TestBase.compute_mydir(__file__)
1515

16-
def setUp(self):
17-
# Call super's setUp().
18-
TestBase.setUp(self)
19-
2016
def test(self):
2117
"""Test that we can have persistent pointer variables"""
2218
self.build()

lldb/packages/Python/lldbsuite/test/commands/expression/weak_symbols/TestWeakSymbols.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,6 @@ def test_weak_symbol_in_expr(self):
2525
self.main_source_file = lldb.SBFileSpec("main.c")
2626
self.do_test()
2727

28-
def setUp(self):
29-
# Call super's setUp().
30-
TestBase.setUp(self)
31-
3228
def run_weak_var_check (self, weak_varname, present):
3329
# The expression will modify present_weak_int to signify which branch
3430
# was taken. Set it to so we don't get confused by a previous run.

lldb/packages/Python/lldbsuite/test/commands/frame/diagnose/array/TestArray.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,6 @@
1212
class TestArray(TestBase):
1313
mydir = TestBase.compute_mydir(__file__)
1414

15-
def setUp(self):
16-
TestBase.setUp(self)
17-
1815
@skipUnlessDarwin
1916
@skipIfDarwinEmbedded # <rdar://problem/33842388> frame diagnose doesn't work for armv7 or arm64
2017
def test_array(self):

lldb/packages/Python/lldbsuite/test/commands/frame/language/TestGuessLanguage.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,6 @@ def test_guess_language(self):
2626
self.build()
2727
self.do_test()
2828

29-
def setUp(self):
30-
# Call super's setUp().
31-
TestBase.setUp(self)
32-
3329
def check_language(self, thread, frame_no, test_lang):
3430
frame = thread.frames[frame_no]
3531
self.assertTrue(frame.IsValid(), "Frame %d was not valid."%(frame_no))

lldb/packages/Python/lldbsuite/test/commands/frame/var/TestFrameVar.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,6 @@ def test_frame_var(self):
2222
self.build()
2323
self.do_test()
2424

25-
def setUp(self):
26-
# Call super's setUp().
27-
TestBase.setUp(self)
28-
2925
def do_test(self):
3026
exe = self.getBuildArtifact("a.out")
3127

lldb/packages/Python/lldbsuite/test/commands/register/register/intel_xtended_registers/TestMPXRegisters.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,6 @@ class RegisterCommandsTestCase(TestBase):
1414

1515
mydir = TestBase.compute_mydir(__file__)
1616

17-
def setUp(self):
18-
TestBase.setUp(self)
19-
2017
@skipIf(compiler="clang")
2118
@skipIf(oslist=no_match(['linux']))
2219
@skipIf(archs=no_match(['i386', 'x86_64']))

lldb/packages/Python/lldbsuite/test/commands/register/register/intel_xtended_registers/mpx_offset_intersection/TestMPXOffsetIntersection.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,6 @@ class MPXOffsetIntersectionTestCase(TestBase):
2121
MPX_CONFIG_REGS = ('bndcfgu', 'bndstatus')
2222
BND_VALUE = '{' + ' '.join(('0xff' for _ in range(16))) + '}'
2323

24-
def setUp(self):
25-
TestBase.setUp(self)
26-
2724
@skipIf(oslist=no_match(['linux']))
2825
@skipIf(archs=no_match(['x86_64']))
2926
def test_mpx_registers_offset_intersection(self):

lldb/packages/Python/lldbsuite/test/commands/target/stop-hooks/TestStopHooks.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,6 @@ def test_stop_hooks_step_out(self):
2424
self.main_source_file = lldb.SBFileSpec("main.c")
2525
self.step_out_test()
2626

27-
def setUp(self):
28-
# Call super's setUp().
29-
TestBase.setUp(self)
30-
3127
def step_out_test(self):
3228
(target, process, thread, bkpt) = lldbutil.run_to_source_breakpoint(self,
3329
"Set a breakpoint here", self.main_source_file)

lldb/packages/Python/lldbsuite/test/commands/version/TestVersion.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,6 @@ class VersionTestCase(TestBase):
66

77
mydir = TestBase.compute_mydir(__file__)
88

9-
def setUp(self):
10-
TestBase.setUp(self)
11-
129
@no_debug_info_test
1310
def test_version(self):
1411
# Should work even when people patch the output,

lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_disable/TestWatchpointDisable.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,6 @@
1111
class TestWatchpointSetEnable(TestBase):
1212
mydir = TestBase.compute_mydir(__file__)
1313

14-
def setUp(self):
15-
# Call super's setUp().
16-
TestBase.setUp(self)
17-
1814
def test_disable_works (self):
1915
"""Set a watchpoint, disable it, and make sure it doesn't get hit."""
2016
self.build()

lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/address_breakpoints/TestAddressBreakpoints.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,6 @@ def test_address_breakpoints(self):
2020
self.build()
2121
self.address_breakpoints()
2222

23-
def setUp(self):
24-
# Call super's setUp().
25-
TestBase.setUp(self)
26-
2723
def address_breakpoints(self):
2824
"""Test address breakpoints set with shared library of SBAddress work correctly."""
2925
exe = self.getBuildArtifact("a.out")

lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/address_breakpoints/TestBadAddressBreakpoints.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,6 @@ def test_bad_address_breakpoints(self):
2020
self.build()
2121
self.address_breakpoints()
2222

23-
def setUp(self):
24-
# Call super's setUp().
25-
TestBase.setUp(self)
26-
2723
def address_breakpoints(self):
2824
"""Test that breakpoints set on a bad address say they are bad."""
2925
target, process, thread, bkpt = \

lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/auto_continue/TestBreakpointAutoContinue.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,6 @@ def launch_it (self, expected_state):
5757

5858
return process
5959

60-
def setUp(self):
61-
# Call super's setUp().
62-
TestBase.setUp(self)
63-
6460
def simple_auto_continue(self):
6561
bpno = self.make_target_and_bkpt()
6662
process = self.launch_it(lldb.eStateExited)

lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_language/TestBreakpointLanguage.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,6 @@ class TestBreakpointLanguage(TestBase):
1414

1515
mydir = TestBase.compute_mydir(__file__)
1616

17-
def setUp(self):
18-
# Call super's setUp().
19-
TestBase.setUp(self)
20-
# Find the line number to break inside main().
21-
2217
def check_location_file(self, bp, loc, test_name):
2318
bp_loc = bp.GetLocationAtIndex(loc)
2419
addr = bp_loc.GetAddress()

lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,6 @@ def test_bad_command_lines(self):
4040
self.build()
4141
self.do_test_bad_options()
4242

43-
def setUp(self):
44-
# Call super's setUp().
45-
TestBase.setUp(self)
46-
4743
def make_target_and_import(self):
4844
target = lldbutil.run_to_breakpoint_make_target(self)
4945
interp = self.dbg.GetCommandInterpreter()

lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-caching/TestDataFormatterCaching.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,6 @@ class TestDataFormatterCaching(TestBase):
88

99
mydir = TestBase.compute_mydir(__file__)
1010

11-
def setUp(self):
12-
TestBase.setUp(self)
13-
1411
def test_with_run_command(self):
1512
"""
1613
Test that hardcoded summary formatter matches aren't improperly cached.

lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/type_summary_list_arg/TestTypeSummaryListArg.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@ class TypeSummaryListArgumentTestCase(TestBase):
1414

1515
mydir = TestBase.compute_mydir(__file__)
1616

17-
def setUp(self):
18-
# Call super's setUp().
19-
TestBase.setUp(self)
20-
2117
@no_debug_info_test
2218
def test_type_summary_list_with_arg(self):
2319
"""Test that the 'type summary list' command handles command line arguments properly"""

lldb/packages/Python/lldbsuite/test/functionalities/history/TestHistoryRecall.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,6 @@ def test_history_recall(self):
2222
"""Test the !N and !-N functionality of the command interpreter."""
2323
self.sample_test()
2424

25-
def setUp(self):
26-
# Call super's setUp().
27-
TestBase.setUp(self)
28-
2925
def sample_test(self):
3026
interp = self.dbg.GetCommandInterpreter()
3127
result = lldb.SBCommandReturnObject()

lldb/packages/Python/lldbsuite/test/functionalities/longjmp/TestLongjmp.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,6 @@ class LongjmpTestCase(TestBase):
1414

1515
mydir = TestBase.compute_mydir(__file__)
1616

17-
def setUp(self):
18-
TestBase.setUp(self)
19-
2017
@skipIfDarwin # llvm.org/pr16769: LLDB on Mac OS X dies in function ReadRegisterBytes in GDBRemoteRegisterContext.cpp
2118
@skipIfFreeBSD # llvm.org/pr17214
2219
@expectedFailureAll(oslist=["linux"], bugnumber="llvm.org/pr20231")

lldb/packages/Python/lldbsuite/test/functionalities/pre_run_dylibs/TestPreRunDylibs.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,6 @@ class TestPreRunLibraries(TestBase):
1010
mydir = TestBase.compute_mydir(__file__)
1111
NO_DEBUG_INFO_TESTCASE = True
1212

13-
def setUp(self):
14-
# Call super's setUp().
15-
TestBase.setUp(self)
16-
1713
@skipIf(oslist=no_match(['darwin','macos']))
1814
def test(self):
1915
"""Test that we find directly linked dylib pre-run."""

lldb/packages/Python/lldbsuite/test/functionalities/stats_api/TestStatisticsAPI.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,6 @@
1010
class TestStatsAPI(TestBase):
1111
mydir = TestBase.compute_mydir(__file__)
1212

13-
def setUp(self):
14-
TestBase.setUp(self)
15-
1613
def test_stats_api(self):
1714
self.build()
1815
exe = self.getBuildArtifact("a.out")

lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/sbapi_support/TestTailCallFrameSBAPI.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,6 @@ def test_tail_call_frame_sbapi(self):
1717
self.build()
1818
self.do_test()
1919

20-
def setUp(self):
21-
# Call super's setUp().
22-
TestBase.setUp(self)
23-
2420
def do_test(self):
2521
exe = self.getBuildArtifact("a.out")
2622

lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/thread_step_out_or_return/TestSteppingOutWithArtificialFrames.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,3 @@ def test_return_past_artificial_frame(self):
9090
self.assertEqual(frame4.GetDisplayFunctionName(), "main")
9191
self.assertFalse(frame2.IsArtificial())
9292

93-
def setUp(self):
94-
# Call super's setUp().
95-
TestBase.setUp(self)

lldb/packages/Python/lldbsuite/test/functionalities/thread/backtrace_limit/TestBacktraceLimit.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@ class BacktraceLimitSettingTest(TestBase):
1414
mydir = TestBase.compute_mydir(__file__)
1515
NO_DEBUG_INFO_TESTCASE = True
1616

17-
def setUp(self):
18-
# Call super's setUp().
19-
TestBase.setUp(self)
20-
2117
def test_backtrace_depth(self):
2218
"""Test that the max-backtrace-depth setting limits backtraces."""
2319
self.build()

lldb/packages/Python/lldbsuite/test/functionalities/tsan/cpp_global_location/TestTsanCPPGlobalLocation.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,6 @@ def test(self):
2424
self.build()
2525
self.tsan_tests()
2626

27-
def setUp(self):
28-
# Call super's setUp().
29-
TestBase.setUp(self)
30-
3127
def tsan_tests(self):
3228
exe = self.getBuildArtifact("a.out")
3329
self.expect(

lldb/packages/Python/lldbsuite/test/functionalities/tsan/global_location/TestTsanGlobalLocation.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,6 @@ def test(self):
2424
self.build()
2525
self.tsan_tests()
2626

27-
def setUp(self):
28-
# Call super's setUp().
29-
TestBase.setUp(self)
30-
3127
def tsan_tests(self):
3228
exe = self.getBuildArtifact("a.out")
3329
self.expect(

lldb/packages/Python/lldbsuite/test/functionalities/tsan/multiple/TestTsanMultiple.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,6 @@ def test(self):
2424
self.build()
2525
self.tsan_tests()
2626

27-
def setUp(self):
28-
# Call super's setUp().
29-
TestBase.setUp(self)
30-
3127
def tsan_tests(self):
3228
exe = self.getBuildArtifact("a.out")
3329
self.expect(

lldb/packages/Python/lldbsuite/test/functionalities/tsan/thread_numbers/TestTsanThreadNumbers.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,6 @@ def test(self):
2424
self.build()
2525
self.tsan_tests()
2626

27-
def setUp(self):
28-
# Call super's setUp().
29-
TestBase.setUp(self)
30-
3127
def tsan_tests(self):
3228
exe = self.getBuildArtifact("a.out")
3329
self.expect(

lldb/packages/Python/lldbsuite/test/functionalities/var_path/TestVarPath.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,6 @@ def test_frame_var(self):
2222
self.build()
2323
self.do_test()
2424

25-
def setUp(self):
26-
# Call super's setUp().
27-
TestBase.setUp(self)
28-
2925
def verify_point(self, frame, var_name, var_typename, x_value, y_value):
3026
v = frame.GetValueForVariablePath(var_name)
3127
self.assertTrue(v.GetError().Success(), "Make sure we find '%s'" % (var_name))

0 commit comments

Comments
 (0)