Skip to content

Commit 9bdeab1

Browse files
committed
[LinkerWrapper][Obvious] Fix dangling stringref on Xcuda-ptxas options
Summary: This accidentally was a dangling reference and caused issues when actually used. Make sure that the memory is saved before the job is created.
1 parent 8c8336f commit 9bdeab1

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -423,8 +423,9 @@ Expected<StringRef> clang(ArrayRef<StringRef> InputFiles, const ArgList &Args) {
423423
CmdArgs.push_back(Args.MakeArgString("--cuda-path=" + CudaBinaryPath));
424424

425425
for (StringRef Arg : Args.getAllArgValues(OPT_ptxas_arg))
426-
llvm::copy(SmallVector<StringRef>({"-Xcuda-ptxas", Arg}),
427-
std::back_inserter(CmdArgs));
426+
llvm::copy(
427+
SmallVector<StringRef>({"-Xcuda-ptxas", Args.MakeArgString(Arg)}),
428+
std::back_inserter(CmdArgs));
428429

429430
for (StringRef Arg : Args.getAllArgValues(OPT_linker_arg_EQ))
430431
CmdArgs.push_back(Args.MakeArgString("-Wl," + Arg));

0 commit comments

Comments
 (0)