Merge pull request #1990 from apple/lldb-Fix-few-easily-correctable-warnings

[lldb] Fix few easily correctable warnings

Author: kastiglione

lldb/source/Expression/REPL.cpp

@@ -196,7 +196,7 @@ static bool ReadCode(const std::string &path, std::string &code,
   const size_t max_size = code.max_size();
   if (file_size > max_size) {
     error_sp->Printf("file at path '%s' too large: "
-                     "file_size = %llu, max_size = %llu\n",
+                     "file_size = %zu, max_size = %zu\n",
                      path.c_str(), file_size, max_size);
     return false;
   }

lldb/source/Plugins/TypeSystem/Swift/SwiftASTContext.cpp

@@ -8342,14 +8342,6 @@ bool SwiftASTContext::CacheUserImports(SwiftASTContext &swift_ast_context,
                                        Status &error) {
   llvm::SmallString<1> m_description;
 
-  swift::ModuleDecl::ImportFilter import_filter {
-      swift::ModuleDecl::ImportFilterKind::Exported,
-      swift::ModuleDecl::ImportFilterKind::Default,
-      swift::ModuleDecl::ImportFilterKind::ImplementationOnly,
-      swift::ModuleDecl::ImportFilterKind::SPIAccessControl,
-      swift::ModuleDecl::ImportFilterKind::ShadowedByCrossImportOverlay
-  };
-
   auto *persistent_expression_state =
       sc.target_sp->GetSwiftPersistentExpressionState(exe_scope);
 

lldb/source/Target/SwiftLanguageRuntimeDynamicTypeResolution.cpp

@@ -965,7 +965,7 @@ llvm::Optional<uint64_t> SwiftLanguageRuntimeImpl::GetMemberVariableOffset(
   }
   if (offset) {
     LLDB_LOGF(GetLogIfAllCategoriesSet(LIBLLDB_LOG_TYPES),
-              "[GetMemberVariableOffset] offset of %s is %d",
+              "[GetMemberVariableOffset] offset of %s is %lld",
               member_name.str().c_str(), *offset);
   } else {
     LLDB_LOGF(GetLogIfAllCategoriesSet(LIBLLDB_LOG_TYPES),
@@ -2033,7 +2033,7 @@ bool SwiftLanguageRuntime::IsTaggedPointer(lldb::addr_t addr,
       // Check whether this is a reference to an Objective-C object.
       if ((addr & 1) == 1)
         return true;
-  }
+  } break;
   default:
     break;
   }
@@ -2098,7 +2098,7 @@ lldb::addr_t SwiftLanguageRuntime::FixupAddress(lldb::addr_t addr,
       if (extra_deref)
         return refd_addr;
     }
-  }
+  } break;
   default:
     break;
   }